fix(reflect): preserve bank attribution in provider calls#2764
Merged
benfrank241 merged 1 commit intoJul 17, 2026
Conversation
Bind Reflect to the existing per-bank ContextVar so its tool loop and final synthesis preserve provider cost attribution. Replace two direct ContextVar implementation tests with one integrated Reflect binding/reset regression.
This was referenced Jul 17, 2026
Contributor
Author
|
Additional integration evidence from the corresponding Will qualification branch:
This validates that binding |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoryEngine.reflect_asyncto the existing per-bank provider-attribution contextContextVarimplementation tests with one integrated Reflect regressionWithout this binding, retain and recall attribute provider usage correctly but Reflect is the only bank-scoped engine operation that loses the bank before its LLM/tool loop.
Validation
uv run pytest tests/test_bank_attribution.py -q— 15 passeduv run ruff check hindsight_api/engine/memory_engine.py tests/test_bank_attribution.pyuv run ruff format --check hindsight_api/engine/memory_engine.py tests/test_bank_attribution.pymain(9676fc1699c199175809285ea0e1095ab71115d0)