feat(api): attribute remote reranker calls by bank#2740
Open
Jordan-Jarvis wants to merge 5 commits into
Open
Conversation
This was referenced Jul 17, 2026
…r-bank-attribution-20260716
…ibution-20260716' into upstream/feat-reranker-bank-attribution-20260716
Contributor
Author
|
Updated the branch to current upstream Validation on the updated head:
|
Contributor
Author
|
@benfrank241 @dcbouius could one of you review this bank-attribution fix? The current head is clean, mergeable, and green, and focused bank/reranker coverage passes. This is required so remote reranker provider usage is attributed through the canonical bank boundary rather than losing tenant ownership. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HINDSIGHT_API_RERANKER_SEND_BANK_AS_HEADERconfigurationX-Hindsight-Bank-Idheader from Hindsight's existing current-bank contextRerankResponseinstead of accepting guessed legacy response shapesThis resolves #2729. The setting remains disabled by default, and the documentation explicitly limits bank attribution to trusted endpoints because enabling it transmits the current bank ID.
The generic Reflect context correction discovered during qualification is submitted independently as #2764 so it can merge without waiting for the reranker feature. This branch currently contains the same correction; once #2764 lands, GitHub will exclude the identical change from this PR's effective diff.
Validation
ty check --ignore unresolved-importpassed for the changed runtime modules (the repository's optional MLX imports are unavailable on this Linux environment)