Skip to content

storage-vm: use this for the vms#269

Open
brianmcgillion wants to merge 3 commits into
tiiuae:mainfrom
brianmcgillion:use-storage-vm
Open

storage-vm: use this for the vms#269
brianmcgillion wants to merge 3 commits into
tiiuae:mainfrom
brianmcgillion:use-storage-vm

Conversation

@brianmcgillion

Copy link
Copy Markdown
Collaborator

Convert to using this now that it is properly exported by the upstream. It is already in the base config for the vms through app-vm.

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run nix flake check and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • Alienware x86_64

Installation Method

  • Requires full re-installation (just build ...installer)
  • Can be updated with just rebuild ...
  • Other:

Test Steps To Verify:

  1. ...

size = 51200;
autoCreate = true;
fsType = "ext4";
directory = "/var/lib/docker";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, docker needs filesystem changes to run

Comment thread modules/microvm/msg/config.nix Outdated
autoCreate = true;
fsType = "ext4";
}
ghaf.storagevm = {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can delete msg-vm now, hasn't been used or worked on since porting

Convert to using this now that it is properly exported by the upstream.
It is already in the base config for the vms through app-vm.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
These have not been used or developed since the project was ported to
using the ghaf baseline.

This is a routine cleanup removing dead and unused functionality.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Remove the resources that were allocated to the message vm and
redistribute them to the other vms.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants