Skip to content

Move volume based shared directories to storage-vm#220

Closed
gngram wants to merge 1 commit into
tiiuae:mainfrom
gngram:pr/vol_to_storagevm
Closed

Move volume based shared directories to storage-vm#220
gngram wants to merge 1 commit into
tiiuae:mainfrom
gngram:pr/vol_to_storagevm

Conversation

@gngram

@gngram gngram commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Description of Changes

Move volume based persistent directories to storage-vm

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run nix flake check and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • Alienware x86_64

Installation Method

  • Requires full re-installation (just build ...installer)
  • Can be updated with just rebuild ...
  • Other:

Test Steps To Verify:

  1. Test general functionality.

Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>

@brianmcgillion brianmcgillion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbssrc

mbssrc commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator

This currently has a couple of problems:

  • docker-vm tpm is not enabled, after enabling it has several boot failures
  • the docker share (/var/lib/docker) running in storage-vm has permission problems, resulting in the setup service to fail (this is after onboarding, when the images are downloaded).
  • the vtpm feature + storagevm in ghaf seem to have some problems as well - e.g. /etc/machine-id is not available during early boot, which results in it being re-generated on each boot, and tmpfile setup fails because of unknown users, which could be a similar issue but with /var/lib/nixos storage

Have done some quick patch for reference:
mbssrc@5791006

@vunnyso vunnyso self-requested a review October 29, 2025 14:52
@brianmcgillion

Copy link
Copy Markdown
Collaborator

#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants