Astroquery (SDSS & Gaia) resolver#3906
Conversation
| exceptions = [] | ||
| for viewer_label in viewer_select.selected: | ||
| viewer = self.app._jdaviz_helper.viewers.get(viewer_label) | ||
| try: | ||
| viewer.data_menu.add_data(data_label) | ||
| except Exception: | ||
| except Exception as e: | ||
| failed_viewers.append(viewer_label) | ||
| exceptions.append(str(e)) | ||
| if len(failed_viewers) > 0: | ||
| msg = f"Failed to add {data_label} to viewers: {', '.join(failed_viewers)}" | ||
| self.app.hub.broadcast(SnackbarMessage(msg, sender=self, color='error')) | ||
| self.app.hub.broadcast(SnackbarMessage(msg, sender=self, color='error', | ||
| traceback=exceptions)) |
There was a problem hiding this comment.
this was to help debug a snackbar error that ended up being no directly related - ticket to debug/fix has been created, but this is still a useful addition
| @@ -50,6 +43,13 @@ class VOResolver(BaseResolver): | |||
| radius_unit_items = List().tag(sync=True) | |||
| radius_unit_selected = Unicode("deg").tag(sync=True) | |||
|
|
|||
| waveband_items = List().tag(sync=True) | |||
| waveband_selected = Any().tag(sync=True) # Any to accept Nonetype | |||
| resource_filter_coverage = Bool(False).tag(sync=True) | |||
| resource_items = List([]).tag(sync=True) | |||
| resource_selected = Any().tag(sync=True) # Any to accept Nonetype | |||
| resources_loading = Bool(False).tag(sync=True) | |||
|
|
|||
There was a problem hiding this comment.
just re-ordering to match the UI a little better and be consistent with ordering in the new resolver
kecnry
requested review from
MatthewPortman,
bmorris3,
cshanahan1,
gibsongreen,
haticekaratay,
javerbukh and
rosteen
as code owners
kecnry
force-pushed
the
resolver-astroquery
branch
from
7220377 to
55ec9a6
Compare
MatthewPortman
left a comment
MatthewPortman
left a comment
There was a problem hiding this comment.
The code looks good but when no results are returned from the query, I get 'No compatible importer found.' I'm not sure if it's in the scope of this ticket but I would prefer that warning to be specific in this case.
To reproduce, I used the GAIA coordinates from the video for and SDSS query.
|
I can probably add an alert similar to the one when the results exceed the max results - let me see if I can get that in this afternoon. EDIT: turned out to be very straightforward, pushing soon. |
|
not sure where the sudden test failure came from - will investigate monday morning |
kecnry
force-pushed
the
resolver-astroquery
branch
from
faebafd to
bcb0820
Compare
3 participants
Description
This pull request achieves feature parity with the catalogs plugin from loaders by implementing a basic astroquery resolver, supporting SDSS and Gaia cone search only, that can feed tables into the catalog resolver (and therefore currently requires the
app.state.catalogs_in_dc = True).Screen.Recording.2025-11-21.at.12.31.31.PM.mov
After this (and removing the dev-flag), the only functionality from catalogs plugin that is not yet implemented are (both planned for upcoming table work):
For this PR, should we put the entire resolver under the catalogs dev-flag since it currently can't load anything else? #3907 could then remove the dev-flag but exclude SDSS/Gaia without the flag set?
Potential future follow-up:
'BqplotImageLayerArtist' object has no attribute 'density_mark'- seems unrelated to this PR and likely affects all catalogsChange log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?