Skip to content

file loader: prevent UI jump when selecting directory#3921

Merged
kecnry merged 1 commit into
spacetelescope:mainfrom
kecnry:is-empty-directory-selected
Dec 5, 2025
Merged

file loader: prevent UI jump when selecting directory#3921
kecnry merged 1 commit into
spacetelescope:mainfrom
kecnry:is-empty-directory-selected

Conversation

@kecnry

@kecnry kecnry commented Dec 2, 2025

Copy link
Copy Markdown
Member

Description

This pull request removes the UI jump when selecting a directory in the file loader (which has the annoying consequence of entering the wrong directory on a double click):

Screen.Recording.2025-12-02.at.1.46.45.PM.mov

It does so by considering a directory selection as still an empty input, and leaves the warning banner in place.

The "input is empty" warning was introduced in #3906 and never released, so this doesn't need a changelog or backport.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • If new remote data is added that uses MAST, is the URI added to the cache-download.yml workflow?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.5 milestone Dec 2, 2025
@kecnry kecnry requested a review from rosteen as a code owner December 2, 2025 18:49
@kecnry kecnry added the trivial Only needs one approval instead of two label Dec 2, 2025
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Dec 2, 2025
@kecnry kecnry merged commit 45699f6 into spacetelescope:main Dec 5, 2025
25 of 29 checks passed
@kecnry kecnry deleted the is-empty-directory-selected branch December 5, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants