MGMT-24682: Remove LSO and LVMS as CNV operator dependencies#10541
Merged
openshift-merge-bot[bot] merged 5 commits intoJul 2, 2026
Merged
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pastequo: This pull request references MGMT-24682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/M
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (22)
🚧 Files skipped from review as they are similar to previous changes (22)
WalkthroughThe PR removes error returns from operator dependency and preflight requirement APIs, updates manager call sites and mocks to match the new signatures, and adjusts CNV-related dependency expectations and a Go imports cache mount. ChangesOperator API, implementations, and manager flow
Estimated code review effort: 4 (Complex) | ~60 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pastequo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/operators/cnv/cnv_operator.go`:
- Around line 67-72: The GetDependencies method on operator currently returns a
nil slice, which will serialize as null in the API response; update it to return
an empty slice instead so the payload shape stays consistent with other
operators. Use the GetDependencies and GetDependenciesFeatureSupportID methods
on operator in cnv_operator.go as the place to fix this, and keep the feature
support IDs and detailed-features expectations aligned by returning an empty
models.FeatureSupportLevelID slice rather than nil.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ac0d94bb-0b01-4338-8ac6-126bffd155e4
📒 Files selected for processing (5)
internal/bminventory/detailed_supported_features_test.gointernal/operators/cnv/cnv_operator.gointernal/operators/cnv/cnv_operator_test.gointernal/operators/manager_test.gosubsystem/operators_test.go
💤 Files with no reviewable changes (1)
- subsystem/operators_test.go
pastequo
force-pushed
the
feat/remove-lvms-lso-as-cnv-dep
branch
from
5e75b65 to
81844cd
Compare
openshift-ci
Bot
added
size/XL
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/operators/nodehealthcheck/node_healthcheck_operator.go`:
- Around line 65-66: The GetDependenciesFeatureSupportID method in operator
currently returns nil, which will serialize as null in models.Operator instead
of an empty array. Update this method to return an empty FeatureSupportLevelID
slice so GetDetailedSupportedFeatures always populates dependencies with []
rather than nil.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b0e74332-2c2a-4625-9657-9e1a90f4e105
📒 Files selected for processing (52)
internal/bminventory/detailed_supported_features_test.gointernal/operators/amdgpu/amd_gpu_operator.gointernal/operators/amdgpu/amd_gpu_operator_test.gointernal/operators/api/api.gointernal/operators/api/mock_operator_api.gointernal/operators/authorino/authorino_operator.gointernal/operators/clusterobservability/cluster_observability_operator.gointernal/operators/clusterobservability/cluster_observability_requirements.gointernal/operators/cnv/cnv_operator.gointernal/operators/cnv/cnv_operator_test.gointernal/operators/fenceagentsremediation/fence_agents_remediation_operator.gointernal/operators/fenceagentsremediation/fence_agents_remediation_requirements.gointernal/operators/kmm/kmm_operator.gointernal/operators/kubedescheduler/kube_descheduler_operator.gointernal/operators/kubedescheduler/kube_descheduler_requirements.gointernal/operators/loki/loki_operator.gointernal/operators/loki/loki_operator_test.gointernal/operators/lso/ls_operator.gointernal/operators/lvm/lvm_operator.gointernal/operators/manager.gointernal/operators/manager_test.gointernal/operators/mce/mce_operator.gointernal/operators/metallb/metallb_operator.gointernal/operators/metallb/metallb_operator_test.gointernal/operators/mtv/operator.gointernal/operators/mtv/operator_test.gointernal/operators/nmstate/operator.gointernal/operators/nodefeaturediscovery/node_feature_discovery_operator.gointernal/operators/nodehealthcheck/node_healthcheck_operator.gointernal/operators/nodehealthcheck/node_healthcheck_requirements.gointernal/operators/nodemaintenance/node_maintenance_operator.gointernal/operators/nodemaintenance/node_maintenance_requirements.gointernal/operators/numaresources/numaresources_operator.gointernal/operators/numaresources/numaresources_requirements.gointernal/operators/nvidiagpu/nvidia_gpu_operator.gointernal/operators/nvidiagpu/nvidia_gpu_operator_test.gointernal/operators/oadp/oadp_operator.gointernal/operators/oadp/oadp_requirements.gointernal/operators/odf/odf_operator.gointernal/operators/openshiftai/openshift_ai_operator.gointernal/operators/openshiftai/openshift_ai_operator_test.gointernal/operators/openshiftlogging/openshift_logging_operator.gointernal/operators/openshiftlogging/openshift_logging_operator_test.gointernal/operators/osc/operator.gointernal/operators/osc/operator_test.gointernal/operators/pipelines/pipelines_operator.gointernal/operators/selfnoderemediation/self_node_remediation_operator.gointernal/operators/selfnoderemediation/self_node_remediation_requirements.gointernal/operators/serverless/serverless_operator.gointernal/operators/servicemesh/servicemesh_operator.goskipper.yamlsubsystem/operators_test.go
💤 Files with no reviewable changes (1)
- subsystem/operators_test.go
✅ Files skipped from review due to trivial changes (2)
- internal/bminventory/detailed_supported_features_test.go
- internal/operators/api/mock_operator_api.go
🚧 Files skipped from review as they are similar to previous changes (1)
- internal/operators/cnv/cnv_operator_test.go
pastequo
force-pushed
the
feat/remove-lvms-lso-as-cnv-dep
branch
2 times, most recently
from
91ff2ba to
6186e2e
Compare
Contributor
Author
|
/retest |
CNV no longer auto-installs Local Storage Operator or Logical Volume Manager Storage when selected. Storage operators must now be enabled explicitly by the user when persistent storage is required. Update unit, manager, and subsystem tests to reflect the new behavior.
pastequo
force-pushed
the
feat/remove-lvms-lso-as-cnv-dep
branch
from
6186e2e to
6503564
Compare
Contributor
Author
|
/retest |
shay23bra
reviewed
Jul 2, 2026
pastequo
force-pushed
the
feat/remove-lvms-lso-as-cnv-dep
branch
from
6503564 to
b9a4461
Compare
Contributor
|
/lgtm |
bfournie
added a commit
to bfournie/agent-installer-utils
that referenced
this pull request
Jul 2, 2026
Include lvms-operator in the list of included operator images. Now that storage operators are removed as CNV dependencies in openshift/assisted-service#10541 including the images allows them to be optionally included.
Contributor
|
/retest |
|
@pastequo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CNV no longer auto-installs Local Storage Operator or Logical Volume Manager Storage when selected. Storage operators must now be enabled explicitly by the user when persistent storage is required.
Update unit, manager, and subsystem tests to reflect the new behavior.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist
Summary by CodeRabbit