NO-ISSUE: Minor style change for operators

pastequo · pastequo · commit 65035642f733 · 2026-07-02T10:43:22.000+02:00
diff --git a/internal/operators/authorino/authorino_operator.go b/internal/operators/authorino/authorino_operator.go
@@ -63,7 +63,7 @@ func (o *operator) GetDependencies(c *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.
diff --git a/internal/operators/clusterobservability/cluster_observability_operator.go b/internal/operators/clusterobservability/cluster_observability_operator.go
@@ -6,6 +6,7 @@ import (
 	"github.com/lib/pq"
 	"github.com/openshift/assisted-service/internal/common"
 	operatorscommon "github.com/openshift/assisted-service/internal/operators/common"
+	"github.com/openshift/assisted-service/internal/operators/openshiftlogging"
 	"github.com/openshift/assisted-service/internal/templating"
 	"github.com/openshift/assisted-service/models"
 	"github.com/sirupsen/logrus"
@@ -51,7 +52,7 @@ func (o *operator) GetFullName() string {
 
 // GetDependencies provides a list of dependencies of the Operator
 func (o *operator) GetDependencies(cluster *common.Cluster) []string {
-	return []string{"openshift-logging"}
+	return []string{openshiftlogging.Operator.Name}
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
diff --git a/internal/operators/cnv/cnv_operator.go b/internal/operators/cnv/cnv_operator.go
@@ -69,7 +69,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/kmm/kmm_operator.go b/internal/operators/kmm/kmm_operator.go
@@ -65,7 +65,7 @@ func (o *operator) GetDependencies(c *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.
diff --git a/internal/operators/kubedescheduler/kube_descheduler_operator.go b/internal/operators/kubedescheduler/kube_descheduler_operator.go
@@ -55,7 +55,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/loki/loki_operator.go b/internal/operators/loki/loki_operator.go
@@ -64,7 +64,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/loki/loki_operator_test.go b/internal/operators/loki/loki_operator_test.go
@@ -46,9 +46,9 @@ var _ = Describe("Loki Operator", func() {
 	})
 
 	Context("GetDependenciesFeatureSupportID", func() {
-		It("should return nil for no dependencies", func() {
+		It("should return no dependencies", func() {
 			deps := operator.GetDependenciesFeatureSupportID()
-			Expect(deps).To(BeNil())
+			Expect(deps).To(BeEmpty())
 		})
 	})
 
diff --git a/internal/operators/lso/ls_operator.go b/internal/operators/lso/ls_operator.go
@@ -45,7 +45,7 @@ func (l *lsOperator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *lsOperator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/lvm/lvm_operator.go b/internal/operators/lvm/lvm_operator.go
@@ -71,7 +71,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/mce/mce_operator.go b/internal/operators/mce/mce_operator.go
@@ -68,7 +68,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.
diff --git a/internal/operators/metallb/metallb_operator.go b/internal/operators/metallb/metallb_operator.go
@@ -68,7 +68,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 
 // GetDependenciesFeatureSupportID returns feature support level IDs for the Operator
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/nmstate/operator.go b/internal/operators/nmstate/operator.go
@@ -55,7 +55,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/nodefeaturediscovery/node_feature_discovery_operator.go b/internal/operators/nodefeaturediscovery/node_feature_discovery_operator.go
@@ -65,7 +65,7 @@ func (o *operator) GetDependencies(c *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.
diff --git a/internal/operators/nodemaintenance/node_maintenance_operator.go b/internal/operators/nodemaintenance/node_maintenance_operator.go
@@ -55,7 +55,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/numaresources/numaresources_operator.go b/internal/operators/numaresources/numaresources_operator.go
@@ -55,7 +55,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/oadp/oadp_operator.go b/internal/operators/oadp/oadp_operator.go
@@ -55,7 +55,7 @@ func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the Operator
diff --git a/internal/operators/openshiftlogging/openshift_logging_operator.go b/internal/operators/openshiftlogging/openshift_logging_operator.go
@@ -9,6 +9,7 @@ import (
 	"github.com/openshift/assisted-service/internal/common"
 	"github.com/openshift/assisted-service/internal/operators/api"
 	operatorscommon "github.com/openshift/assisted-service/internal/operators/common"
+	"github.com/openshift/assisted-service/internal/operators/loki"
 	"github.com/openshift/assisted-service/internal/templating"
 	"github.com/openshift/assisted-service/models"
 	"github.com/sirupsen/logrus"
@@ -61,7 +62,7 @@ func (o *operator) GetFullName() string {
 // GetDependencies provides a list of dependencies of the Operator
 func (o *operator) GetDependencies(cluster *common.Cluster) []string {
 	// OpenShift Logging depends on Loki Operator
-	return []string{"loki"}
+	return []string{loki.Operator.Name}
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
diff --git a/internal/operators/pipelines/pipelines_operator.go b/internal/operators/pipelines/pipelines_operator.go
@@ -71,7 +71,7 @@ func (o *operator) GetDependencies(c *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.
diff --git a/internal/operators/serverless/serverless_operator.go b/internal/operators/serverless/serverless_operator.go
@@ -71,7 +71,7 @@ func (o *operator) GetDependencies(c *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.
diff --git a/internal/operators/servicemesh/servicemesh_operator.go b/internal/operators/servicemesh/servicemesh_operator.go
@@ -71,7 +71,7 @@ func (o *operator) GetDependencies(c *common.Cluster) []string {
 }
 
 func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {
-	return nil
+	return []models.FeatureSupportLevelID{}
 }
 
 // GetClusterValidationIDs returns cluster validation IDs for the operator.

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func (o operator) GetDependencies(c common.Cluster) []string {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`66`		`- return nil`
	`66`	`+ return []models.FeatureSupportLevelID{}`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`// GetClusterValidationIDs returns cluster validation IDs for the operator.`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ func (o operator) GetDependencies(cluster common.Cluster) []string {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`72`		`- return nil`
	`72`	`+ return []models.FeatureSupportLevelID{}`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`// GetClusterValidationIDs returns cluster validation IDs for the Operator`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ func (o operator) GetDependencies(c common.Cluster) []string {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`68`		`- return nil`
	`68`	`+ return []models.FeatureSupportLevelID{}`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`// GetClusterValidationIDs returns cluster validation IDs for the operator.`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func (o operator) GetDependencies(cluster common.Cluster) []string {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`58`		`- return nil`
	`58`	`+ return []models.FeatureSupportLevelID{}`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`// GetClusterValidationIDs returns cluster validation IDs for the Operator`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func (o operator) GetDependencies(cluster common.Cluster) []string {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`67`		`- return nil`
	`67`	`+ return []models.FeatureSupportLevelID{}`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`// GetClusterValidationIDs returns cluster validation IDs for the Operator`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func (l lsOperator) GetDependencies(cluster common.Cluster) []string {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`func (o *lsOperator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`48`		`- return nil`
	`48`	`+ return []models.FeatureSupportLevelID{}`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`// GetClusterValidationIDs returns cluster validation IDs for the Operator`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ func (o operator) GetDependencies(cluster common.Cluster) []string {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`74`		`- return nil`
	`74`	`+ return []models.FeatureSupportLevelID{}`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`// GetClusterValidationIDs returns cluster validation IDs for the Operator`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func (o operator) GetDependencies(cluster common.Cluster) []string {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`func (o *operator) GetDependenciesFeatureSupportID() []models.FeatureSupportLevelID {`
`71`		`- return nil`
	`71`	`+ return []models.FeatureSupportLevelID{}`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`// GetClusterValidationIDs returns cluster validation IDs for the operator.`