Skip to content

chore: default OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE to true (backport of #2035) #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwinjosechittilappilly merged 3 commits into from
Jul 15, 2026
Merged

chore: default OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE to true (backport of #2035) #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78c6316
feat: add dedicated OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE flag for COS "s…
edwinjosechittilappilly Jul 6, 2026
229a6cc
make shareall default as true (#2035)
edwinjosechittilappilly Jul 6, 2026
308eca0
Merge remote-tracking branch 'origin/main' into backport/2035-shareal…
edwinjosechittilappilly Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/config/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,10 +529,10 @@ def _resolve_skip_os_security_default() -> str:

# Show the "Make documents available to all users" (shared) toggle for COS bucket
# ingestion, independent of OPENRAG_SHOW_PROVIDER_INGEST_SETTINGS. Deployments that
# hide the general per-upload ingest tuning knobs (e.g. SaaS) can still opt back into
# just this toggle by setting this flag on its own.
# hide the general per-upload ingest tuning knobs (e.g. SaaS) still get just this
# toggle. On by default; set to "false" to hide it.
OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE = os.getenv(
"OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE", "false"
"OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE", "true"
).lower() in ("true", "1", "yes")

# Ingest sample data configuration
Expand Down
7 changes: 6 additions & 1 deletion tests/unit/config/test_show_shared_upload_toggle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,14 @@ def _read_flag(env: dict[str, str]) -> str:
return result.stdout.splitlines()[-1].strip()


def test_defaults_false_when_unset():
def test_defaults_true_when_unset():
env = {"PYTHONPATH": str(SRC)}
env.pop("OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE", None)
assert _read_flag(env) == "True"


def test_false_when_disabled():
env = {"OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE": "false", "PYTHONPATH": str(SRC)}
assert _read_flag(env) == "False"


Expand Down
Loading