Skip to content

chore: default OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE to true (backport of #2035)#2093

Merged
edwinjosechittilappilly merged 3 commits into
mainfrom
backport/2035-shareall-default-true
Jul 15, 2026
Merged

chore: default OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE to true (backport of #2035)#2093
edwinjosechittilappilly merged 3 commits into
mainfrom
backport/2035-shareall-default-true

Conversation

@edwinjosechittilappilly

@edwinjosechittilappilly edwinjosechittilappilly commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backports #2035 from release-saas-ga-0.6.2 to main.

Changes the default value of OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE to true.

Depends on #2092 (backport of #2025, which introduces the flag) — this branch is stacked on top of backport/2025-shared-upload-toggle-flag and should be merged after it, or rebased onto main once #2092 lands.

Test plan

  • CI passes
  • Manually verify the toggle defaults to enabled

Summary by CodeRabbit

  • New Features

    • Added an independent setting to control visibility of the “Make documents available to all users” upload toggle.
    • Advanced ingestion options can now be hidden while keeping the shared-upload option available.
    • Shared-upload behavior is now configurable separately from advanced ingestion settings.
  • Bug Fixes

    • Improved upload setting visibility and handling based on configured preferences.
  • Tests

    • Added coverage for default, enabled, disabled, and independent toggle behavior.

edwinjosechittilappilly and others added 2 commits July 14, 2026 14:38
…hare all" toggle (#2025)

* feature Flag Share all

* style: apply biome auto-fixes [skip ci]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot added frontend 🟨 Issues related to the UI/UX backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests labels Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 24dce1d7-53b4-4b0c-836e-867050b7f16b

📥 Commits

Reviewing files that changed from the base of the PR and between 7fb88fd and 229a6cc.

📒 Files selected for processing (7)
  • frontend/app/api/queries/useGetSettingsQuery.ts
  • frontend/components/cloud-picker/ingest-settings.tsx
  • frontend/components/connectors/shared-bucket-view.tsx
  • src/api/settings/endpoints.py
  • src/api/settings/models.py
  • src/config/settings.py
  • tests/unit/config/test_show_shared_upload_toggle.py

Walkthrough

Adds an environment-controlled shared upload toggle, exposes it through the settings API, and updates the cloud-picker UI to display shared upload controls independently from advanced ingest settings.

Changes

Shared upload toggle

Layer / File(s) Summary
Settings flag contract
src/config/settings.py, src/api/settings/models.py, src/api/settings/endpoints.py, frontend/app/api/queries/useGetSettingsQuery.ts, tests/unit/config/test_show_shared_upload_toggle.py
Adds and validates the environment flag, includes it in the settings response, and extends the frontend settings type.
Cloud-picker toggle integration
frontend/components/connectors/shared-bucket-view.tsx, frontend/components/cloud-picker/ingest-settings.tsx
Separates shared-toggle visibility from advanced ingest settings, conditionally renders the corresponding controls, and gates the upload payload’s shared field.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: enhancement

Suggested reviewers: lucaseduoli, ricofurtado

Sequence Diagram(s)

sequenceDiagram
  participant SettingsAPI
  participant SharedBucketView
  participant IngestSettings
  SettingsAPI->>SharedBucketView: Return show_shared_upload_toggle
  SharedBucketView->>SharedBucketView: Compute shared-toggle visibility
  SharedBucketView->>IngestSettings: Pass shared and advanced visibility
  IngestSettings-->>SharedBucketView: Collect upload settings
  SharedBucketView->>SettingsAPI: Submit shared field when enabled
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: enabling OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE by default.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backport/2035-shareall-default-true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

React Doctor skipped this pull request — it changed no React files.

Reviewed by React Doctor for commit 308eca0.

@mpawlow mpawlow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 1

  • ✅ Approved / LGTM 🚀

@github-actions github-actions Bot added the lgtm label Jul 14, 2026
…l-default-true

# Conflicts:
#	src/config/settings.py
#	tests/unit/config/test_show_shared_upload_toggle.py
@edwinjosechittilappilly
edwinjosechittilappilly merged commit 5075e03 into main Jul 15, 2026
43 of 45 checks passed
@github-actions
github-actions Bot deleted the backport/2035-shareall-default-true branch July 15, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) frontend 🟨 Issues related to the UI/UX ignore-for-release lgtm tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants