chore: default OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE to true (backport of #2035)#2093
Conversation
…hare all" toggle (#2025) * feature Flag Share all * style: apply biome auto-fixes [skip ci] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughAdds an environment-controlled shared upload toggle, exposes it through the settings API, and updates the cloud-picker UI to display shared upload controls independently from advanced ingest settings. ChangesShared upload toggle
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant SettingsAPI
participant SharedBucketView
participant IngestSettings
SettingsAPI->>SharedBucketView: Return show_shared_upload_toggle
SharedBucketView->>SharedBucketView: Compute shared-toggle visibility
SharedBucketView->>IngestSettings: Pass shared and advanced visibility
IngestSettings-->>SharedBucketView: Collect upload settings
SharedBucketView->>SettingsAPI: Submit shared field when enabled
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor skipped this pull request — it changed no React files. Reviewed by React Doctor for commit |
mpawlow
left a comment
There was a problem hiding this comment.
Code Review 1
- ✅ Approved / LGTM 🚀
…l-default-true # Conflicts: # src/config/settings.py # tests/unit/config/test_show_shared_upload_toggle.py
Summary
Backports #2035 from
release-saas-ga-0.6.2tomain.Changes the default value of
OPENRAG_SHOW_SHARED_UPLOAD_TOGGLEtotrue.Depends on #2092 (backport of #2025, which introduces the flag) — this branch is stacked on top of
backport/2025-shared-upload-toggle-flagand should be merged after it, or rebased ontomainonce #2092 lands.Test plan
Summary by CodeRabbit
New Features
Bug Fixes
Tests