Skip to content

feat: add dedicated OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE flag for COS "share all" toggle (backport of #2025)#2092

Merged
edwinjosechittilappilly merged 2 commits into
mainfrom
backport/2025-shared-upload-toggle-flag
Jul 15, 2026
Merged

feat: add dedicated OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE flag for COS "share all" toggle (backport of #2025)#2092
edwinjosechittilappilly merged 2 commits into
mainfrom
backport/2025-shared-upload-toggle-flag

Conversation

@edwinjosechittilappilly

@edwinjosechittilappilly edwinjosechittilappilly commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backports #2025 from release-saas-ga-0.6.2 to main.

Adds a dedicated OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE flag to gate the COS "share all" upload toggle.

Test plan

  • CI passes
  • Manually verify the toggle is gated by the new flag

Summary by CodeRabbit

  • New Features

    • Added configuration support for independently showing a shared-upload toggle.
    • Added settings visibility control for advanced ingestion options, including embedding, chunking, OCR, and image descriptions.
    • Shared upload controls now appear independently from other ingestion settings.
  • Bug Fixes

    • Improved handling of shared-upload settings so they are only displayed and submitted when enabled.
  • Tests

    • Added coverage for default, enabled, and independent configuration behavior.

…hare all" toggle (#2025)

* feature Flag Share all

* style: apply biome auto-fixes [skip ci]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot added frontend 🟨 Issues related to the UI/UX backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests enhancement 🔵 New feature or request labels Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c7f743f4-fdf8-4b7c-bf07-ee3fdb75b27c

📥 Commits

Reviewing files that changed from the base of the PR and between 7fb88fd and 78c6316.

📒 Files selected for processing (7)
  • frontend/app/api/queries/useGetSettingsQuery.ts
  • frontend/components/cloud-picker/ingest-settings.tsx
  • frontend/components/connectors/shared-bucket-view.tsx
  • src/api/settings/endpoints.py
  • src/api/settings/models.py
  • src/config/settings.py
  • tests/unit/config/test_show_shared_upload_toggle.py

Walkthrough

Adds an environment-controlled shared upload toggle flag, exposes it through /settings, and updates frontend ingestion controls so shared upload visibility is independent from advanced ingest settings.

Changes

Shared upload toggle

Layer / File(s) Summary
Backend flag and settings contract
src/config/settings.py, src/api/settings/..., tests/unit/config/test_show_shared_upload_toggle.py
Adds and tests OPENRAG_SHOW_SHARED_UPLOAD_TOGGLE, then returns it as show_shared_upload_toggle in SettingsResponse.
Frontend ingestion control contract
frontend/app/api/queries/useGetSettingsQuery.ts, frontend/components/cloud-picker/ingest-settings.tsx
Adds the settings field and conditionally renders advanced ingestion controls through the new showAdvancedSettings prop.
Shared bucket integration
frontend/components/connectors/shared-bucket-view.tsx
Derives shared-toggle visibility, gates the sync payload, and renders shared-only ingestion settings when enabled.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: lucaseduoli, ricofurtado

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding the dedicated shared-upload toggle feature flag for the COS share-all UI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backport/2025-shared-upload-toggle-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Jul 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 37e6ce0.

@mpawlow mpawlow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 1

  • ✅ Approved / LGTM 🚀
  • Only thing missing is execution of CI tests

@github-actions github-actions Bot added the lgtm label Jul 14, 2026
@edwinjosechittilappilly
edwinjosechittilappilly merged commit 5388298 into main Jul 15, 2026
46 of 49 checks passed
@github-actions
github-actions Bot deleted the backport/2025-shared-upload-toggle-flag branch July 15, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) enhancement 🔵 New feature or request frontend 🟨 Issues related to the UI/UX lgtm tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants