Skip to content

[ide-debugger] Minimal version of aptos-core changes to support debugger#19899

Open
mkurnikov wants to merge 12 commits into
mainfrom
debug-value-extracted
Open

[ide-debugger] Minimal version of aptos-core changes to support debugger#19899
mkurnikov wants to merge 12 commits into
mainfrom
debug-value-extracted

Conversation

@mkurnikov

@mkurnikov mkurnikov commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Debugger itself lives in my repo for now, but the plan is to move it into the monorepo eventually.
https://github.com/aptos-labs/aptos-debugger

Note:
Global mutex -> thread-local change for context is for debugger tests to work, otherwise they step onto each other.


Note

Medium Risk
Thread-local debug stepping replaces a process-wide mutex, which changes behavior when MOVE_VM_STEP runs concurrently; most code is behind debugger but the tracing refactor affects stepping-enabled tests.

Overview
Adds a debugger Cargo feature across the Move CLI, VM runtime, VM types, and move-unit-test so IDE-style debugging can plug in without affecting default builds.

VM stepping and debug hooks are refactored: DebugContext is a trait (default MoveStepDebugContext), the debug module is public, and stepping state moves from a global mutex to thread-local storage so parallel debugger/unit tests can install custom contexts and toggles per worker. New APIs include set_debug_context, set_debugging_enabled, capture_debug_thread_state, and get_source_locator.

Interpreter and values expose debugger-only introspection (get_frame_locals, load_struct_type, stack depth, public value/container types, Locals::borrow_values).

Aptos source mapping resolves modules by name when on-chain addresses differ from local dev addresses, and lists known source files for the IDE.

move-unit-test propagates captured debug thread state into each Rayon thread when the feature is enabled.

Reviewed by Cursor Bugbot for commit 6eefe0c. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread third_party/move/move-vm/runtime/Cargo.toml Outdated
@mkurnikov mkurnikov force-pushed the debug-value-extracted branch from 495e3d6 to 657c5bc Compare June 1, 2026 14:57

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 657c5bc. Configure here.

Comment thread aptos-move/cli/src/source_locator.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant