[IDE debugger] Refactor VM values_impl.rs debugging code#19766
Closed
mkurnikov wants to merge 4 commits into
Closed
[IDE debugger] Refactor VM values_impl.rs debugging code#19766mkurnikov wants to merge 4 commits into
values_impl.rs debugging code#19766mkurnikov wants to merge 4 commits into
Conversation
…r threads Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 131606e. Configure here.
f5f59e5 to
06d614c
Compare
06d614c to
0e10f82
Compare
Collaborator
Author
|
Superseded by #19899 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Extracted from #19580.
Note
Medium Risk
Touches VM debugging/trace plumbing and value pretty-printing, which can affect developer tooling and test output; main risk is regressions in debug formatting or thread-local propagation rather than runtime execution semantics.
Overview
Refactors the Move VM debugger by splitting the old monolithic
debug.rsinto adebugmodule with separate stdin-command handling and an interpreter-facingInterpreterDebugInterface(now includesget_stack_depthandload_struct_type).Reworks source/locals/value rendering:
source_locatornow builds local name metadata, formats locals via a new typedDebugValueserializer (supporting struct/enum field names and special-casingstring::String), and exposesget_source_locator(); the oldvalues_impl.rsdebug printer is replaced withvalues_impl/debug.rsplus tests.Makes debugging state thread-local in
tracing(debug enablement +DebugContext) and updates parallel test runners (move-unit-test, transactional runner) to propagate the source locator and debugging flags to Rayon threads and to usesource_locator::print_valuefor output.Reviewed by Cursor Bugbot for commit 0e10f82. Bugbot is set up for automated code reviews on this repo. Configure here.