Skip to content

[IDE debugger] Refactor VM values_impl.rs debugging code#19766

Closed
mkurnikov wants to merge 4 commits into
mainfrom
refactor-vm-debugging
Closed

[IDE debugger] Refactor VM values_impl.rs debugging code#19766
mkurnikov wants to merge 4 commits into
mainfrom
refactor-vm-debugging

Conversation

@mkurnikov

@mkurnikov mkurnikov commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Extracted from #19580.


Note

Medium Risk
Touches VM debugging/trace plumbing and value pretty-printing, which can affect developer tooling and test output; main risk is regressions in debug formatting or thread-local propagation rather than runtime execution semantics.

Overview
Refactors the Move VM debugger by splitting the old monolithic debug.rs into a debug module with separate stdin-command handling and an interpreter-facing InterpreterDebugInterface (now includes get_stack_depth and load_struct_type).

Reworks source/locals/value rendering: source_locator now builds local name metadata, formats locals via a new typed DebugValue serializer (supporting struct/enum field names and special-casing string::String), and exposes get_source_locator(); the old values_impl.rs debug printer is replaced with values_impl/debug.rs plus tests.

Makes debugging state thread-local in tracing (debug enablement + DebugContext) and updates parallel test runners (move-unit-test, transactional runner) to propagate the source locator and debugging flags to Rayon threads and to use source_locator::print_value for output.

Reviewed by Cursor Bugbot for commit 0e10f82. Bugbot is set up for automated code reviews on this repo. Configure here.

…r threads

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mkurnikov mkurnikov requested a review from a team as a code owner May 15, 2026 13:57

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 131606e. Configure here.

Comment thread third_party/move/move-vm/runtime/src/debug/mod.rs
@mkurnikov mkurnikov force-pushed the refactor-vm-debugging branch from 06d614c to 0e10f82 Compare May 16, 2026 18:24
@mkurnikov

Copy link
Copy Markdown
Collaborator Author

Superseded by #19899

@mkurnikov mkurnikov closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant