Skip to content

fix: avoid duplicate day badge from animated header #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesha-antonov merged 1 commit into from
Jun 18, 2026
Merged

fix: avoid duplicate day badge from animated header #2747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/MessagesContainer/components/DayAnimated/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,17 @@
}), [relativeScrolledPositionToBottomOfDay, containerHeight, dayTopOffset, isLoadingAnim])

const contentStyle = useAnimatedStyle(() => ({
opacity: opacity.value,
}), [opacity])
// Only show the floating header once the current day's inline separator has
// scrolled off the top (relativeScrolledPositionToBottomOfDay < 0). While the
// inline separator is still on screen (>= 0) it already shows the date, so
// hiding the floating copy avoids a duplicate date badge (#2709).
opacity: opacity.value * interpolate(
relativeScrolledPositionToBottomOfDay.value,
[-0.0001, 0],
[1, 0],
'clamp'
),
}), [opacity, relativeScrolledPositionToBottomOfDay])

const fadeOut = useCallback(() => {
'worklet'
Expand All @@ -92,7 +101,7 @@

useAnimatedReaction(
() => [scrolledY.value, daysPositionsArray],
(value, prevValue) => {

Check warning on line 104 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (24) 

React Hook useAnimatedReaction has missing dependencies: 'daysPositionsArray' and 'scrolledY.value'. Either include them or remove the dependency array

Check warning on line 104 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (24) 

React Hook useAnimatedReaction was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies

Check warning on line 104 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (22) 

React Hook useAnimatedReaction has missing dependencies: 'daysPositionsArray' and 'scrolledY.value'. Either include them or remove the dependency array

Check warning on line 104 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (22) 

React Hook useAnimatedReaction was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies
if (!isScrolledOnMount.value) {
isScrolledOnMount.value = true
return
Expand All @@ -110,7 +119,7 @@

useAnimatedReaction(
() => createdAtDate.value,
(value, prevValue) => {

Check warning on line 122 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (24) 

React Hook useAnimatedReaction has a missing dependency: 'createdAtDate.value'. Either include it or remove the dependency array

Check warning on line 122 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (24) 

React Hook useAnimatedReaction was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies

Check warning on line 122 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (22) 

React Hook useAnimatedReaction has a missing dependency: 'createdAtDate.value'. Either include it or remove the dependency array

Check warning on line 122 in src/MessagesContainer/components/DayAnimated/index.tsx

View workflow job for this annotation

GitHub Actions / checks (22) 

React Hook useAnimatedReaction was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies
if (value && value !== prevValue)
runOnJS(setCreatedAt)(value)
},
Expand Down
Loading