fix: avoid duplicate day badge from animated header#2747
Merged
Conversation
After aligning the animated header's date with the visible group, the floating header could briefly show the same date as the inline day separator while that separator was still on screen, producing a stacked duplicate date badge during scroll. Gate the floating header's opacity on relativeScrolledPositionToBottomOfDay: only show it once the current day's inline separator has scrolled off the top (< 0). While the inline separator is still visible (>= 0) it already shows the date, so the floating copy stays hidden - a clean handoff with no duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2709
After #2709 aligned the animated day header's date with the visible group, an edge case surfaced: while scrolling, the floating header could show the same date as the inline day separator while that separator was still on screen, producing a stacked duplicate date badge (two "10 June" / two "17 June").
Fix
Gate the floating header's opacity on
relativeScrolledPositionToBottomOfDay: show it only once the current day's inline separator has scrolled off the top (< 0). While the inline separator is visible (>= 0) it already shows the date, so the floating copy stays hidden - a clean handoff, mirroring the inline separator's own opacity flip.Validation (Android simulator, multi-day chat)
tsc,eslint,buildpass; CI (Node 22 & 24) gates this PR.