Prune time tracking#744
Open
wildsor wants to merge 7 commits into
Open
Conversation
wildsor
force-pushed
the
remove-time-accounting
branch
3 times, most recently
from
300d7c8 to
01cc36c
Compare
wildsor
added
the
python-packaging-risk
This was referenced May 27, 2026
This is a holdover from the old codebase. Performance testing is now separated from unit tests.
This is a holdover from when Desbordante was solely a benchmarking tool. Right now this value is not used anywhere meaningful but people still have to insert the useless time accounting logic to comply with the interface.
These statements are intertwined with actual algorithm code, making it more confusing to read. The statements are also not useful to a user of the library. I suspect all of these were either leftovers from testing code or were inserted because people thought it was important, given that execution times were returned from Execute.
These values were not used anywhere. Looks like this stuff was cargo-culted from other algorithms.
This function was only used for time accounting.
Removing time accounting made some execution methods have only a single method call, the one actually doing the work. Moved the work directly to the execution methods.
wildsor
force-pushed
the
remove-time-accounting
branch
from
01cc36c to
0a938f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are four areas where time is tracked in the project:
The
ExecuteInternalvalue has long gone unused but people implement its calculation to comply with the interface. The CIND/IND public methods are not used anywhere, looks like they were part of some preliminary testing.I don't think logging random timings provides any benefit to the user or to the developer. It looks like these logs were either used for some preliminary testing or cargo-culted from other algorithms. I decided to remove them.
Algorithm timeouts are technically part of the implementation and need a bit more thinking to get right, I decided to leave them as is for now.