Simplify single-statement ExecuteInternal methods

Removing time accounting made some execution methods have only a single
method call, the one actually doing the work. Moved the work directly to
the execution methods.

Author: wildsor

src/core/algorithms/cind/cind_verifier/cind_verifier.cpp

@@ -151,10 +151,6 @@ void CINDVerifier::LoadDataInternal() {
 }
 
 void CINDVerifier::ExecuteInternal() {
-    VerifyCIND();
-}
-
-void CINDVerifier::VerifyCIND() {
     model::TableIndex const lhs_table_idx = 0;
     model::TableIndex const rhs_table_idx =
             (input_tables_.size() == 1) ? 0

src/core/algorithms/cind/cind_verifier/cind_verifier.h

@@ -54,8 +54,6 @@ class CINDVerifier final : public Algorithm {
     void LoadDataInternal() final;
     void ExecuteInternal() final;
 
-    void VerifyCIND();
-
 public:
     CINDVerifier();
 

src/core/algorithms/fd/afd_metric/afd_metric_calculator.cpp

@@ -46,10 +46,6 @@ void AFDMetricCalculator::LoadDataInternal() {
 }
 
 void AFDMetricCalculator::ExecuteInternal() {
-    CalculateMetric();
-}
-
-void AFDMetricCalculator::CalculateMetric() {
     auto num_rows = relation_->GetNumRows();
     auto lhs_pli = relation_->CalculatePLIWS(lhs_indices_);
     auto rhs_pli = relation_->CalculatePLIWS(rhs_indices_);

src/core/algorithms/fd/afd_metric/afd_metric_calculator.h

@@ -27,8 +27,6 @@ class AFDMetricCalculator : public Algorithm {
 
     long double result_ = 0.L;
 
-    void CalculateMetric();
-
     void RegisterOptions();
 
     void ResetState() final {

src/core/algorithms/gdd/gdd_validator/gdd_validator.cpp

@@ -8,10 +8,6 @@
 
 namespace algos {
 
-void GddValidator::ExecuteInternal() {
-    FilterValidGdds();
-}
-
 void GddValidator::ResetState() {
     result_.clear();
     counterexamples_.clear();
@@ -33,7 +29,7 @@ void GddValidator::LoadDataInternal() {
     graph_ = parser::graph_parser::gdd::ReadGraph(graph_path_);
 }
 
-void GddValidator::FilterValidGdds() {
+void GddValidator::ExecuteInternal() {
     ResetState();
 
     std::size_t gdd_index = 0;

src/core/algorithms/gdd/gdd_validator/gdd_validator.h

@@ -18,7 +18,6 @@ class GddValidator : public Algorithm {
     std::vector<model::Gdd> result_;
     std::vector<GddCounterexample> counterexamples_;
 
-    void FilterValidGdds();
     void RegisterOptions();
 
     virtual void ExecuteInternal() final;

src/core/algorithms/ind/ind_verifier/ind_verifier.cpp

@@ -77,7 +77,7 @@ void INDVerifier::LoadDataInternal() {
     /* Do nothing, we don't prepocess any data before executing. */
 }
 
-void INDVerifier::VerifyIND() {
+void INDVerifier::ExecuteInternal() {
     /* Ensure, that all rows have model::IDatasetStream::GetNumberOfColumns() values. */
     using FixedStream = model::DatasetStreamFixed<model::IDatasetStream*>;
     /* Perform a projection of the fixed dataset stream. */
@@ -135,8 +135,4 @@ void INDVerifier::VerifyIND() {
     error_ = static_cast<Error>(GetViolatingClustersCount()) / lhs_cardinality;
 }
 
-void INDVerifier::ExecuteInternal() {
-    VerifyIND();
-}
-
 }  // namespace algos

src/core/algorithms/ind/ind_verifier/ind_verifier.h

@@ -44,8 +44,6 @@ class INDVerifier final : public Algorithm {
 
     void LoadDataInternal() final;
 
-    void VerifyIND();
-
     void ExecuteInternal() final;
 
 public:

src/core/algorithms/md/md_verifier/md_verifier.cpp

@@ -96,10 +96,6 @@ void MDVerifier::MakeExecuteOptsAvailable() {
     MakeOptionsAvailable({kRightTable, kLeftTable, kMDLHS, kMDRHS, kThreads});
 }
 
-void MDVerifier::ExecuteInternal() {
-    VerifyMD();
-}
-
 model::MD MDVerifier::BuildMD(std::vector<ColumnSimilarityClassifier> const& lhs,
                               ColumnSimilarityClassifier const& rhs) {
     auto column_matches = std::make_shared<std::vector<model::md::ColumnMatch>>();
@@ -151,7 +147,7 @@ MDValidationCalculator MDVerifier::CreateValidator() const {
     return validator;
 }
 
-void MDVerifier::VerifyMD() {
+void MDVerifier::ExecuteInternal() {
     input_md_ = BuildMD(lhs_, rhs_);
     highlights_ = std::make_shared<MDHighlights>(input_md_->GetDescription().rhs);
 

src/core/algorithms/md/md_verifier/md_verifier.h

@@ -40,7 +40,6 @@ class MDVerifier : public Algorithm {
     void ResetState() override;
 
     void RegisterOptions();
-    void VerifyMD();
 
     MDValidationCalculator CreateValidator() const;