Update System.Security.Cryptography.Xml patch version 10.0.6 => 10.0.10#1167
Open
jbriaris wants to merge 1 commit into
Open
Update System.Security.Cryptography.Xml patch version 10.0.6 => 10.0.10#1167jbriaris wants to merge 1 commit into
jbriaris wants to merge 1 commit into
Conversation
Author
|
Worth being aware of the same vulnerability being present in System.ServiceModel.Primitives |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Current version of System.Security.Cryptography.Xml is vulnerable. MS have a patch that fixes this.
Solution
Bump version of System.Security.Cryptography.Xml from 10.0.6 to 10.0.10
Note
I noticed several pre-existing test failures exist in the current master branch unrelated to this change:
• V2Encoder null assertion crash in Proactor thread causes NetMQConfig.Cleanup() to hang, blocking subsequent tests
• SimpleReqRepWithRelaxedSucceeds hangs due to unread SendFrame
• MonitorDisposeProperlyWhenDisposedAfterMonitoredTcpSocket demonstrates an unresolved monitor disposal bug
It is possible that these test failures are the result of our IT setup or possibly existing failures on master branch? I can't see how they would be related to this simple patch update.