Modifications to allow overriding paths#51
Open
pascalim wants to merge 1 commit into
Open
Conversation
Owner
|
Hi ! |
Author
|
It allows the container to be less dependent on the host, where you wouldn't necessarily want/have access to the host file system. While one solution would be to make a custom image with the overridden configs, this brings in a security issue where the ssh key and the account hashes got baked in the image.
Example in swarm mode:
service:
satis:
...
secrets:
- id_rsa
- config.php
environment:
SATIS_ID_RSA: /var/run/secrets/id_rsa
SATIS_CONFIG: : /var/run/secrets/config.php
… On Apr 21, 2017, at 11:42 AM, Yannick Pereira-Reis ***@***.***> wrote:
Hi !
Thanks for your contrib but I don't really understand why you need to override these paths ?
Bye.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes:
SATIS_REPO, SATIS_CONFIG, SATIS_ID_RSAto allow overriding the pathsHope you have some use for it! :)