feat(settings): functional persisted settings — theme, accent, branding, thresholds, data (epic #29)#39
Merged
Merged
Conversation
…ng, thresholds, data A real Settings area where every control persists and visibly takes effect across the app. - Core: AppTheme + AppSettings + a RuntimeSettings holder (the single in-memory source the layout, branding, and confidence tiers read). - Persistence: single-row AppSettingsRecord + migration; loaded into RuntimeSettings at startup. - Infrastructure: ISettingsStore (get/save, sanitizes accent hex + clamps/orders thresholds) and IDataMaintenance (clear all documents, reseed the demo corpus). - Web: Settings page (theme light/dark/system, recolorable accent palette, product name, confidence tiers, default export template, data management) + rail nav. App.razor applies the theme (no-flash inline script) and injects the validated accent; Brand and CockpitFormat now read RuntimeSettings, so renaming the product and retuning the tiers take effect app-wide. The review Export menu surfaces the default template first. - Tests: settings store (defaults, persistence, sanitize), confidence-tier wiring, and clear-all. 25 unit + 12 integration + 3 e2e green. Refs #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real Settings area — every control persists and visibly takes effect across the app.
data-theme).--accentoverride; works in light and dark. Proven: dark + indigo applied app-wide after save.Brandnow readsRuntimeSettings, so the rail/titles/headers follow.CockpitFormatreads them).Architecture: one
RuntimeSettingsholder is the in-memory source; the store loads it at startup and on every save. Single-rowAppSettingsRecord+ migration. Accent hex is sanitized server-side and re-validated before injection (no untrusted content reaches the page).Proof
dotnet formatclean · 25 unit + 12 integration + 3 e2e green.Refs #29