Quick brush resize using Ctrl+Click in sketch pane#898
Open
eliemichel wants to merge 3 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables quick and intuitive resizing of the brush directly in the sketch pane using Control+click.
Known limitations:
Displayed cursor jumps at the end of resizing. We would need a way to move mouse from code to fix this properly. Is there a way to do so?
There is a quatum issue occuring sometime when starting, likely due to the saving of the toolbar state. This sets the app in an inconsistent state though we override the value of
state.isQuickResizingin Toolbar's constructor. We need to discuss that.It'd be nice to augment the gizmo with a little indicator of the mouse position while resizing the brush, but the code of
SketchPane.createAlphaThresholdBorder()is still a bit obscure to us (and stuffed with some TODOs of yours). Should we move the cursor drawing into the strategy?We should eventually make it resize the eraser when using right click.