fix(wasix): Fix EFD_SEMAPHORE eventfd read value#6533
Open
artemyarulin wants to merge 2 commits into
Open
Conversation
Contributor
Author
Shield - Regression 💩💩💩
More changed tests
Install shield
Artifacts
|
218c820 to
18fde78
Compare
Collaborator
|
@artemyarulin Can we close the PR now as it was used just for testing? |
Contributor
Author
|
Sorry, it was used for testing, but it's an actual fix, so ready for the review |
Collaborator
|
EDITTED: done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WASIX
eventfd(EFD_SEMAPHORE)reads returning the full counter value instead of1.In semaphore mode, Linux
eventfdsemantics require each successful read to return1and decrement the counter by one. The WASIX notification counter was already decrementing one permit, but returned the pre-decrement counter, so reading after writing4returned4.Closes #6145