fix(language-service): prevent crash on malformed html.customData configuration#6127
Open
WangKepeople wants to merge 3 commits into
Open
fix(language-service): prevent crash on malformed html.customData configuration#6127WangKepeople wants to merge 3 commits into
WangKepeople wants to merge 3 commits into
Conversation
KazariEX
reviewed
Jul 22, 2026
KazariEX
reviewed
Jul 22, 2026
Member
|
The error report seems to indicate that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a server crash (
TypeError: paths is not iterable) when an LSP client returns an array containingnullelements (e.g.,[null]) for the unconfiguredhtml.customDataoption.Context
Some non-VS Code LSP clients (such as Emacs Eglot) respond to
workspace/configurationrequests with[null]when a configuration section is not explicitly set in the workspace settings.Currently,
(await context.env.getConfiguration?.("html.customData")) ?? []evaluates to[null](since[null]is truthy), causing the subsequentfor (const path of paths)loop to assignnulltopathand throw a runtime error insidegetCustomData().Changes
nullor falsy items from thehtml.customDataarray usingArray.isArray(rawPaths) ? rawPaths.filter(Boolean) : [].