Skip to content

[Dashboard] Improve signal config enum and domain selection controls#2152

Merged
AayushSaini101 merged 4 commits into
vllm-project:mainfrom
wilsonwu:add-new-domain-ui
Jun 15, 2026
Merged

[Dashboard] Improve signal config enum and domain selection controls#2152
AayushSaini101 merged 4 commits into
vllm-project:mainfrom
wilsonwu:add-new-domain-ui

Conversation

@wilsonwu

Copy link
Copy Markdown
Contributor

PLEASE FILL IN THE PR DESCRIPTION BELOW AND CONFIRM THE CHECKLIST ITEMS.

Closes N/A

Purpose

  • Replace the Dashboard embedding signal Aggregation Method free-text input with a dropdown using the supported enum values.
  • Replace the Domain signal MMLU Categories textarea with a richer category picker that supports:
    • selecting one or more preset MMLU domain categories
    • adding one or more custom categories
    • removing selected categories as tags
  • These changes reduce invalid user input, make supported values easier to discover, and preserve extensibility for custom domain labels.
  • Affected module(s): Dashboard

Test Plan

  • Run make dashboard-check.
  • Run focused frontend checks:
    • npm run lint
    • npm run type-check
    • npm run test:unit
  • This validation is sufficient because the change is scoped to Dashboard config UI rendering and form serialization. It does not change router runtime behavior, backend handlers, or the config file schema.

Test Result

  • make dashboard-check passed.
  • Focused frontend checks passed:
    • npm run lint
    • npm run type-check
    • npm run test:unit
  • Frontend unit tests passed: 11 test files, 40 tests.
  • Existing npm audit warnings and Sass/Svelte deprecation warnings were printed during dashboard checks, but they are unrelated to this PR and did not fail validation.
  • No follow-up blockers identified.

Semantic Router PR Checklist
  • PR title uses module-aligned prefixes such as [Router], [CLI], [Dashboard], [Operator], [Fleet-Sim], [Bindings], [Training], [E2E], [Docs], or [CI/Build]
  • If the PR spans multiple modules, the title includes all relevant prefixes
  • Commits in this PR are signed off with git commit -s
  • The Purpose, Test Plan, and Test Result sections reflect the actual scope, commands, and blockers for this change

See CONTRIBUTING.md for the full contributor workflow and commit guidance.

@wilsonwu wilsonwu requested review from Xunzhuo and rootfs as code owners June 11, 2026 05:20
@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit e26c14c
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6a2fe5db384c620008355578
😎 Deploy Preview https://deploy-preview-2152--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 dashboard

Owners: @Xunzhuo, @JaredforReal, @haowu1234, @szedan-rh, @yehuditkerido, @henschwartz
Files changed:

  • dashboard/frontend/src/pages/ConfigPageDomainCategoryPicker.module.css
  • dashboard/frontend/src/pages/ConfigPageDomainCategoryPicker.tsx
  • dashboard/frontend/src/pages/ConfigPageSignalsSection.tsx

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

✅ Supply Chain Security Report — All Clear

Scanner Status Findings
AST Codebase Scan (Py, Go, JS/TS, Rust) 19 finding(s) — MEDIUM: 12 · LOW: 7
AST PR Diff Scan No issues detected
Regex Fallback Scan No issues detected

Scanned at 2026-06-15T11:46:29.716Z · View full workflow logs

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@wilsonwu wilsonwu force-pushed the add-new-domain-ui branch from e015093 to d350dd7 Compare June 11, 2026 05:21
@wilsonwu

Copy link
Copy Markdown
Contributor Author

The CI process encountered instability with the Docker image registry, reviewer who can help to trigger a retry, thank you.

@AayushSaini101

Copy link
Copy Markdown
Collaborator

thanks for the MR @wilsonwu can you share the screenshots of the improvements thanks 🙏

@wilsonwu

Copy link
Copy Markdown
Contributor Author

thanks for the MR @wilsonwu can you share the screenshots of the improvements thanks 🙏

Yes, I've optimized the UI of Domain Signal, making it easy and quick to select multiple preset domains, and also allowing for custom domain selection.

image

Both the editing interface and the view interface are functioning normally.

image image

@AayushSaini101 AayushSaini101 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 🙏

@AayushSaini101 AayushSaini101 merged commit bc59b4e into vllm-project:main Jun 15, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants