feat!: inline projects extend the root config by default#10750
Open
sheremet-va wants to merge 17 commits into
Open
feat!: inline projects extend the root config by default#10750sheremet-va wants to merge 17 commits into
sheremet-va wants to merge 17 commits into
Conversation
github-actions
Bot
added
the
maybe automated
sheremet-va
removed
the
maybe automated
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
commented
Jul 10, 2026
sheremet-va
marked this pull request as draft
July 10, 2026 09:42
sheremet-va
marked this pull request as ready for review
July 23, 2026 16:07
…true # Conflicts: # packages/vitest/src/node/plugins/workspace.ts # packages/vitest/src/node/projects/resolveProjects.ts
…true # Conflicts: # packages/vitest/src/node/plugins/workspace.ts # packages/vitest/src/node/projects/resolveProjects.ts
…true # Conflicts: # packages/vitest/src/node/config/propagation.ts # packages/vitest/src/node/plugins/workspace.ts # packages/vitest/src/node/projects/resolveProjects.ts
sheremet-va
commented
Jul 23, 2026
| } | ||
| } | ||
|
|
||
| /** |
Member
Author
There was a problem hiding this comment.
It is a bit of a mind fck, but I don't see a better way. viteOverrides were a mistake!
macarie
previously approved these changes
Jul 24, 2026
macarie
left a comment
macarie
left a comment
Member
There was a problem hiding this comment.
Looks good from what I can tell (given my limited knowledge of this part) 👍🏼
|
|
||
| ::: tip Referencing the Current Config | ||
| If you want to keep the user configuration, you can specify the `extends` property. All other properties will be merged with the user defined config. | ||
| Inline configurations inherit the root config by default. If you want to inherit the configuration of a specific project instead, set the `extends` property to its config file. All other properties will be merged with the user defined config. |
Member
There was a problem hiding this comment.
I'm not sure the relationship between "a specific project" and "its config file" (like why is it a different config file?) is clear, but I have no idea how to word it differently...
Member
Author
There was a problem hiding this comment.
Changed to
If you want to inherit a specific configuration file instead, set the
extendsproperty to its path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extendsnow defaults totrue: inline projects inherit all options from the root config, including plugins. Setextends: falseto keep the project isolated.nameandprojectsare never inherited.globalSetupis not inherited from the root config because it already runs once per test run (extending a non-root config still inherits it). The project's owntagsreplace the inherited array.createVitest/startVitest, so inheritance works even when there is no root config file. Rootpluginsfrom the programmatic config are not inherited because their instances are owned by the root server. The programmaticbrowserconfiguration is also not inherited: its instances describe a single project, and inheriting them would create duplicate instance names (the--browserflags have the same guard).experimentaloptions propagation is removed; the values are inherited like everything else, andextends: falsediscards them.--experimental.*CLI flags are applied to every project like the other project-level CLI flags.Projects referenced as config files or directories are not affected. Documented in the migration guide and the projects guide.
Resolves #7225
Stacked on #10823, which deduplicates the run-level option copies and adds the "Project Configuration Resolution" section to the advanced guide; this PR updates that section for the new semantics.