fix(mental-models): align stale checks with refresh tag scope#2804
Open
r266-tech wants to merge 1 commit into
Open
fix(mental-models): align stale checks with refresh tag scope#2804r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
Contributor
|
Verified this at
The added cases cover the important scope boundaries: default One scope note for #2800: this fixes stale-check/refresh disagreement, but it intentionally does not change the refresh recall semantics that produced the reporter's zero-result case; the documented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all_strictdefaults and explicittags_matchbehaviortrigger.tag_groupswhen deciding whether a scheduled refresh is stalefact_typesas an additional scope constraintWhy
The scheduled-refresh gate and the refresh itself currently resolve tag scope differently. Refresh uses
_resolve_refresh_tag_filtering(), includingtag_groupsand the tagged-modelall_strictdefault, whilecompute_mental_model_is_stale()ignorestag_groupsand defaults tagged models toany.That can mark a model stale because of an out-of-scope memory, spend an unnecessary refresh LLM call, and then refresh against a different (or empty) corpus. This was surfaced while tracing #2800.
Testing
uv run pytest tests/test_mental_models.py::TestMentalModelStaleness -q -n 0(12 passed)uv run ruff format hindsight_api/engine/memory_engine.py tests/test_mental_models.pyuv run ruff check hindsight_api/engine/memory_engine.pyThe regression coverage includes default
all_strict, explicitany, compound tag groups, untagged/global behavior, and flat/group tag filters composed withfact_types, including multi-group near misses.Related to #2800.