fix(audit): add missing @audited decorator to api_update_memory#2798
Open
handnewb wants to merge 1 commit into
Open
fix(audit): add missing @audited decorator to api_update_memory#2798handnewb wants to merge 1 commit into
handnewb wants to merge 1 commit into
Conversation
The PATCH /memories/{memory_id} endpoint (curate/invalidate/revert)
was the only data-mutation endpoint without an audit trail. All other
mutation endpoints (delete_memory, update_document, delete_document,
create_mental_model, etc.) have @Audited decorators.
This ensures memory curation operations are recorded in the audit log
for compliance and forensic traceability.
Found during cybersecurity audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PATCH /v1/default/banks/{bank_id}/memories/{memory_id}endpoint (curate/invalidate/revert) was the only data-mutation endpoint without an audit trail. All other mutation endpoints have@audited:delete_memory→@audited("delete_memory")update_document→@audited("update_document")delete_document→@audited("delete_document")create_mental_model→@audited("create_mental_model")update_memory→ ❌ (missing)Changes
@audited("update_memory")decorator toapi_update_memoryVerification
@app.patch(...)and beforeasync def, matching the pattern of all other audited endpointsFound during cybersecurity audit.