fix: add DELETE /banks/{bank_id}/memories/{memory_id} endpoint and MCP delete_memory tool#2784
Open
handnewb wants to merge 7 commits into
Open
fix: add DELETE /banks/{bank_id}/memories/{memory_id} endpoint and MCP delete_memory tool#2784handnewb wants to merge 7 commits into
handnewb wants to merge 7 commits into
Conversation
…P delete_memory tool
Previously the delete_memory_unit engine method had no HTTP endpoint
or MCP tool exposure, making single-memory deletion impossible via API.
This adds:
- DELETE /v1/default/banks/{bank_id}/memories/{memory_id} returning DeleteResponse
- MCP tool 'delete_memory' (hindsight_forget) registered in both DEFAULT_TOOLS and _DESTRUCTIVE_TOOLS
- Audited operation with proper 404/400/500 error handling
Closes vectorize-io#2523
…point
- Regenerated openapi.json from HTTP endpoint (DELETE /banks/{bank_id}/memories/{memory_id})
- Updated skills/hindsight-docs/references/openapi.json
- Regenerated Python client (memory_api.py) with delete_memory method
- Added Go client DeleteMemory API (api_memory.go)
- Updated Go OpenAPI YAML (openapi.yaml) with delete endpoint
- Added TypeScript SDK deleteMemory function (sdk.gen.ts)
- Added TypeScript DeleteMemoryData types (types.gen.ts)
Fixes CI verify-generated-files check.
…te Go YAML - Regenerated Go OpenAPI YAML via Docker openapi-generator (exact CI match) - Added DeleteMemoryData/Errors/Responses imports to TypeScript sdk.gen.ts
Generated via @hey-api/openapi-ts v0.88.0 with @hey-api/client-fetch and @hey-api/typescript peer dependencies installed. The previous manual changes did not match the auto-generator output format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the
delete_memory_unitengine method existed but had no HTTP endpoint or MCP tool exposure, making single-memory deletion impossible via API. The only way to delete individual memories was through bulk operations or direct DB access.Changes
DELETE /v1/default/banks/{bank_id}/memories/{memory_id}returningDeleteResponsedelete_memoryregistered in bothDEFAULT_TOOLSand_DESTRUCTIVE_TOOLS@audited("delete_memory")Verification
delete_documentendpoint andinvalidate_memoryMCP toolCloses #2523