fix(retain): preserve structured envelope fields across oversized chunks#2760
Closed
r266-tech wants to merge 1 commit into
Closed
fix(retain): preserve structured envelope fields across oversized chunks#2760r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
Member
|
Thanks @r266-tech — thorough work, and the test coverage (losslessness, idempotency, plain-text fallback for ambiguous shapes, envelope preservation) is exactly right for this kind of change. Verified locally on the PR head:
Routing the merge decision to @nicoloboschi rather than merging directly, for two reasons:
No blocking concerns from me — the diff is well-bounded (recursion/fragment/expansion caps), lint + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role,timestamp,id, andpath, while retaining the plain-text fallback for ambiguous shapesTesting
uv run pytest tests/test_chunking.py -q(44 passed)uv run pytest tests/test_structured_chunk_size_retain.py -q -n 0uv run --frozen ty check hindsight_api./scripts/hooks/lint.shFixes #2548