Skip to content

fix(embed): defer provider credential validation#2746

Merged
benfrank241 merged 1 commit into
vectorize-io:mainfrom
oldnicke:fix/2732-defer-provider-credentials
Jul 17, 2026
Merged

fix(embed): defer provider credential validation#2746
benfrank241 merged 1 commit into
vectorize-io:mainfrom
oldnicke:fix/2732-defer-provider-credentials

Conversation

@oldnicke

Copy link
Copy Markdown
Contributor

Summary

  • remove the embed wrapper CLI credential allowlist and defer validation to the selected provider
  • add regression coverage proving a no-key provider configuration is forwarded to the daemon
  • clarify that the LLM API key requirement depends on the selected provider

Closes #2732

Testing

  • UV_CACHE_DIR=/tmp/hindsight-uv-cache ./scripts/hooks/lint.sh
  • UV_CACHE_DIR=/tmp/hindsight-uv-cache uv run ruff format --check hindsight_embed tests/test_cli_forwarding.py
  • UV_CACHE_DIR=/tmp/hindsight-uv-cache uv run ruff check hindsight_embed tests/test_cli_forwarding.py
  • UV_CACHE_DIR=/tmp/hindsight-uv-cache uv run ty check hindsight_embed
  • UV_CACHE_DIR=/tmp/hindsight-uv-cache uv run pytest -p no:rerunfailures tests/ -q (147 passed)

@benfrank241
benfrank241 merged commit 52b893b into vectorize-io:main Jul 17, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(embed): defer provider credential requirements to the selected daemon provider

2 participants