Skip to content

Show bank names in control-plane selector#2718

Closed
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:rios/bank-selector-name-label
Closed

Show bank names in control-plane selector#2718
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:rios/bank-selector-name-label

Conversation

@koriyoshi2041

Copy link
Copy Markdown
Contributor

Summary

  • render a bank's display name in the control-plane selector when one is present
  • keep the canonical bank_id as the hover title and copy value
  • add focused coverage for name, null-name, and blank-name fallback behavior

Closes #2714

Tests

  • npm run test -- tests/lib/bank-label.test.ts
  • npm run test
  • npm run build

@koriyoshi2041

Copy link
Copy Markdown
Contributor Author

Closing this because I found the same selector-label fix is already covered by #2693 and #2715. Sorry for the duplicate noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control plane bank selector renders bank_id instead of the bank's name (display label already fetched but unused)

1 participant