cpu: x64: drop write permissions after JIT complete - #5690
Open
thiagomacieira wants to merge 1 commit into
Open
Conversation
`Xbyak::CodeGenerator` allocates RW pages for us when used in AutoGrow mode (good). Since we don't need to write to the JIT'ted content after we've finished our initial pass, we can drop the `PROT_WRITE` permissions and retain only Read-Execute. This is required in some locked down systems that forbid RWX for security reasons.
github-actions
Bot
added
the
platform:cpu-x64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xbyak::CodeGeneratorallocates RW pages for us when used in AutoGrow mode (good). Since we don't need to write to the JIT'ted content after we've finished our initial pass, we can drop thePROT_WRITEpermissions and retain only Read-Execute. This is required in some locked down systems that forbid RWX for security reasons.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?There are no new failures. Before and after:
Performance improvements
Bug fixes
This is not easy to unit-test. I caught this when intercepting
mmap()andmprotect()when the protection arguments hadPROT_WRITE|PROT_EXEC.