docs: correct opt-in build notes for kafka and mithril#945
Conversation
The batteries-included PR (#944) described mithril as "unsupported on Windows MSVC", but the green `--all-features` Windows CI check shows its GMP/blst C-crypto crates build and statically link there. Mithril is opt-in because it's a heavy C toolchain (large binary + long build), not for portability reasons. Also fix the kafka note: it now pulls a vendored OpenSSL build (wired to the `kafka` feature), so opt-in builds need a C compiler + Perl rather than the platform's system OpenSSL dev libraries. No behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughComments in ChangesFeature exclusion rationale clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #944 fixing two inaccurate notes about the opt-in (source-build) integrations. Docs/comments only — no behaviour change.
cargo check --all-featuresWindows CI check disproves that: mithril's GMP/blst C-crypto crates build and statically link on windows-msvc. It's opt-in because it's a heavy C toolchain (larger binary, much longer build), not for portability.kafkafeature pulls a vendored OpenSSL build, opt-in builds need a C compiler + Perl, not the platform's system OpenSSL dev libraries.zeromqnote to make the real reason explicit: it dynamically links a systemlibzmqat runtime, so it can't ship in a portable prebuilt binary.Touches the
[package.metadata.dist]comment inCargo.tomland the two installation docs.🤖 Generated with Claude Code
Summary by CodeRabbit