docs: replace dead mainnet relay in v2 docs and CONTRIBUTING#940
Conversation
📝 WalkthroughWalkthroughAll documentation files and the contributing guide replace the Cardano mainnet relay endpoint ChangesMainnet Relay Endpoint Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The v2 docs and CONTRIBUTING still referenced relays-new.cardano-mainnet.iohk.io:3001, which no longer resolves (NXDOMAIN), so copy-pasted config snippets and `oura watch` commands fail to connect. Point them at the live backbone.mainnet.cardanofoundation.org:3001 relay, matching the example configs fixed in #939. (v1 docs are maintained on the lts/v1 branch and fixed separately.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0c697b1 to
cdba433
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/v1/sources/n2n.mdx (1)
56-63:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep the testnet example on a testnet relay.
This block is labeled
testnet, but it now points at the mainnet backbone endpoint, so copying it withmagic = "testnet"will not work. As shown bysrc/sources/n2n.rs, the configured peer string is used verbatim at connect time.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/v1/sources/n2n.mdx` around lines 56 - 63, The testnet example in the N2N configuration block contains an inconsistency: the address field points to the mainnet backbone endpoint (backbone.mainnet.cardanofoundation.org:3001) while the magic field specifies testnet. This mismatch will cause connection failures since the peer string is used verbatim at connect time. Update the address field in the toml code block to point to an actual testnet relay endpoint instead of the mainnet backbone, ensuring the configuration matches the testnet magic value.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/v1/sources/n2n.mdx`:
- Around line 56-63: The testnet example in the N2N configuration block contains
an inconsistency: the address field points to the mainnet backbone endpoint
(backbone.mainnet.cardanofoundation.org:3001) while the magic field specifies
testnet. This mismatch will cause connection failures since the peer string is
used verbatim at connect time. Update the address field in the toml code block
to point to an actual testnet relay endpoint instead of the mainnet backbone,
ensuring the configuration matches the testnet magic value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c6bb1b3f-8872-40c2-8dbc-69d526b8780b
📒 Files selected for processing (11)
.github/CONTRIBUTING.mddocs/v1/advanced/rollback_buffer.mdxdocs/v1/installation/docker.mdxdocs/v1/sources/n2n.mdxdocs/v1/usage/daemon.mdxdocs/v1/usage/dump.mdxdocs/v1/usage/watch.mdxdocs/v2/sources/n2n.mdxdocs/v2/usage/daemon.mdxdocs/v2/usage/dump.mdxdocs/v2/usage/watch.mdx
The v2 docs and
CONTRIBUTING.mdstill referencedrelays-new.cardano-mainnet.iohk.io:3001, which no longer resolves (NXDOMAIN).Copy-pasted config snippets and
oura watchcommands using it fail to connect.Swept it to the live
backbone.mainnet.cardanofoundation.org:3001relay,matching the example configs fixed in #939. Hostname-only change.
The v1 docs are maintained on the
lts/v1branch and are fixed in a separate PRtargeting that branch.
🤖 Generated with Claude Code