-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[Website] Full-bleed hero/testimonials, nav restructure, OpenNext deploy config #21794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6c2c861
feat(twenty-website-redone): bleed hero and testimonials backgrounds …
mabdullahabaid 717d76e
feat(twenty-website-redone): promote Why to top-level nav, hide Produ…
mabdullahabaid b820640
chore(twenty-website-redone): port OpenNext Cloudflare deployment config
mabdullahabaid 95dd309
fix(twenty-website-redone): restore current-page highlight in the men…
mabdullahabaid 08c6f0c
style(twenty-website-redone): drop comments from menu/notch/section-s…
mabdullahabaid c1d02b1
chore(twenty-website-redone): drop catalog-sync check from lint
mabdullahabaid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| NEXTJS_ENV=development | ||
|
|
||
| # Stripe — use a test-mode key locally | ||
| STRIPE_SECRET_KEY= | ||
|
|
||
| # Enterprise JWT — generate a test RSA keypair for local dev | ||
| ENTERPRISE_JWT_PRIVATE_KEY= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { defineCloudflareConfig } from '@opennextjs/cloudflare'; | ||
| import r2IncrementalCache from '@opennextjs/cloudflare/overrides/incremental-cache/r2-incremental-cache'; | ||
| import { withRegionalCache } from '@opennextjs/cloudflare/overrides/incremental-cache/regional-cache'; | ||
|
|
||
| // Worker custom-domain hostnames bypass the zone-level Cache Rule for | ||
| // synthetic responses (OpenNext builds responses from R2 reads rather than | ||
| // `fetch()`-ing an origin). Wrapping the R2 incremental cache with the | ||
| // regional cache means cache-hit reads come from CF's per-region Cache API | ||
| // (~10ms) instead of R2 (~100ms), recovering most of the TTFB the migration | ||
| // lost. | ||
| const incrementalCache = withRegionalCache(r2IncrementalCache, { | ||
| mode: 'long-lived', | ||
| }); | ||
|
|
||
| const baseConfig = defineCloudflareConfig({ | ||
| incrementalCache, | ||
| }); | ||
|
|
||
| // `defineCloudflareConfig` only takes the `CloudflareOverrides` subset of the | ||
| // config today; `skewProtection` lives directly under `cloudflare.*` and has to | ||
| // be merged in. See packages/cloudflare/src/api/config.ts in opennextjs-cloudflare. | ||
| export default { | ||
| ...baseConfig, | ||
| cloudflare: { | ||
| ...baseConfig.cloudflare, | ||
| skewProtection: { | ||
| enabled: true, | ||
| // Window large enough to keep prod-version history for skew routing AND | ||
| // hold one slot per open PR preview. `maxVersionAgeDays` prunes the rest. | ||
| maxNumberOfVersions: 50, | ||
| maxVersionAgeDays: 14, | ||
| }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-44.5 KB
(57%)
packages/twenty-website-redone/public/images/menu/developers.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-47.3 KB
(57%)
packages/twenty-website-redone/public/images/menu/user-guide.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
65 changes: 0 additions & 65 deletions
65
packages/twenty-website-redone/scripts/check-translations.mjs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
initOpenNextCloudflareForDev()called unconditionally will hangnext typegenand leave open handles in Jest tests. The Cloudflare dev context binds active Node process handles (R2 incremental cache, env wrangler context) that prevent clean process exit in non-dev commands.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The premise that the call is "unconditional" and therefore binds live handles in every command is incorrect. initOpenNextCloudflareForDev() is written to be called unconditionally (that's the official OpenNext pattern), but it self-guards before doing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it — thanks for the correction.