Remove encryption legacy#21781
Open
prastoin wants to merge 5 commits into
Open
Conversation
…back decryptVersioned now throws on non-enc:v2 envelopes instead of falling back to legacy AES-CTR. Update the application-variable and application-registration-variable integration tests to assert the live read path surfaces an error for legacy ciphertext rather than transparently decrypting them.
Contributor
TODOs/FIXMEs:
|
🔍 Automated Pre-Review✅ No issues detected - This PR is ready for human review. Automated pre-review — human approval still required. |
prastoin
added
the
ci:allow-previous-version-upgrade-mutation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found and verified against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
🚀 Preview Environment Ready! Your preview environment is available at: https://baker-entrance-literacy-solomon.trycloudflare.com This environment will automatically shut down after 5 hours. |
Weiko
reviewed
Jun 18, 2026
Weiko
left a comment
Weiko
left a comment
Member
There was a problem hiding this comment.
Code LGTM but I'll let @charlesBochet validate if we can deprecate or not as I didn't really follow that track 👍
charlesBochet
left a comment
charlesBochet
left a comment
Member
There was a problem hiding this comment.
TBH,
- I would just rename decryptVersioned to decryptWithFallbackForUpgradeCommandDeprecated. I would not touch upgrade command (only this renaming in the calls)
- I would call decrypt in the production code
That's should be a few line of changes and not such a big change
charlesBochet
added
-PR: awaiting author
-PR: draft
and removed
-PR: awaiting review
-PR: awaiting author
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Still preserving the cross-upgrade flow
close twentyhq/core-team-issues#2465