Infer record pickers for record-typed logic function workflow inputs#21494
Open
bosiraphael wants to merge 36 commits into
Open
Infer record pickers for record-typed logic function workflow inputs#21494bosiraphael wants to merge 36 commits into
bosiraphael wants to merge 36 commits into
Conversation
Add objectUniversalIdentifier to input schemas so logic function inputs typed as workspace records (e.g. companies: Company[]) render as record single/multi selects with a variable picker in the workflow builder. Inference resolves inline handler types against standard and app objects during the manifest build; explicit schemas can set the field directly. Update the People Data Labs enrichment inputs as reference.
|
👋 Thanks for contributing to Twenty! Your PR has been set to draft while you work on it. Once you're done, mark it as Ready for review and our automated checks will run. Looking forward to your contribution! |
Visual Regression Report✅ No visual changes detected across 225 stories. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 31 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Visual Regression Report (twenty-new-ui)✅ No visual changes detected across 225 stories. |
🔍 Automated Pre-Review✅ No issues detected - This PR is ready for human review. Automated pre-review — human approval still required. |
Contributor
There was a problem hiding this comment.
1 issue found across 7 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
…ord-inputs # Conflicts: # packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormSingleRecordPicker.tsx
…ing stale schemas
twenty-ci-bot-public
Bot
added
external-needs-triage
and removed
external-needs-triage
labels
Contributor
There was a problem hiding this comment.
2 issues found across 37 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…ord-inputs # Conflicts: # packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormSingleRecordPicker.tsx
Visual Regression Report (twenty-front)
Changed stories
4 new stories
|
…n logic function input docs
charlesBochet
added
-PR: awaiting review
-PR: awaiting author
and removed
-PR: awaiting author
-PR: awaiting review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Logic functions can declare workflow inputs typed as records or arrays of records (e.g. the People Data Labs enrichment functions), but the workflow builder rendered those as a plain text input with a variable picker, which is not usable.
What this does
objectUniversalIdentifierlink on input schema properties, so a record-typed input is tied to a workspace object.TwentyRecord<'objectUniversalIdentifier'>marker type in the handler signature, reading the object's universal identifier straight from the source; explicit input schemas can still set the field directly.TwentyRecord<UID>is a brandedstring, so the handler signature reflects that it receives ids (a bound variable resolves to whatever the referenced step produced).+Nbadge (reusingExpandableList) and its variable picker offers both record objects and fields.