feat(twenty-partners): expose partnerScope on list + by-slug endpoints by rashad · Pull Request #21126 · twentyhq/twenty

rashad · 2026-06-02T04:51:17Z

What

Adds partnerScope (the partner Categories multi-select) to the output of the two public partner endpoints:

list-available-partners (/s/partners)
get-partner-by-slug (/s/partner-by-slug)

Additive only — deploymentExpertise is kept, so existing consumers (the current live marketplace) are unaffected.

Why

Part of the partner marketplace rework. The website marketplace (companion branch rk-rework-marketplace-cards) consumes partnerScope to show/filter partner Categories. The new options + migration live in the signup app PR #21040.

Merge order (we'll decide)

Independent diff — can merge in any order. Couplings to keep in mind:

Version line: this branch and feat(twenty-partners): submit-partner-application HTTP logic function #21040 both bump the app package.json version; whoever merges second re-bumps.
Deploy (not merge): the partners app is deployed manually. Deploy the final combined app (this + feat(twenty-partners): submit-partner-application HTTP logic function #21040) and run yarn migrate:partner-scope:prod before the website is deployed.

github-actions · 2026-06-02T04:53:30Z

	Fails
🚫	`node` failed.

Log

Details

�[31mError: �[39m SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:4337:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6985:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5908:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:104:5)�[39m
danger-results://tmp/danger-results-bb87280b.json

Generated by 🚫 dangerJS against 89239d2

twenty-ci-bot-public · 2026-06-02T06:27:33Z

🔍 Automated Pre-Review

✅ No issues detected - This PR is ready for human review.

View details

Automated pre-review. Human approval still required.

cubic-dev-ai

2 issues found across 4 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-apps/internal/twenty-partners/src/logic-functions/get-partner-by-slug.logic-function.ts">

<violation number="1" location="packages/twenty-apps/internal/twenty-partners/src/logic-functions/get-partner-by-slug.logic-function.ts:10">
P2: Big duplicate partner shape/query added. This will drift and break consistency when fields evolve. Extract shared type/query fragment.</violation>

<violation number="2" location="packages/twenty-apps/internal/twenty-partners/src/logic-functions/get-partner-by-slug.logic-function.ts:90">
P2: Public route returns raw error message. This leaks internal backend details to anyone calling endpoint. Return a generic error string.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-06-02T06:30:43Z

+type CurrencyValue = { amountMicros: number; currencyCode: string } | null;
+type LinkValue = { primaryLinkUrl: string | null } | null;
+
+type Partner = {


P2: Big duplicate partner shape/query added. This will drift and break consistency when fields evolve. Extract shared type/query fragment.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-apps/internal/twenty-partners/src/logic-functions/get-partner-by-slug.logic-function.ts, line 10: <comment>Big duplicate partner shape/query added. This will drift and break consistency when fields evolve. Extract shared type/query fragment.</comment> <file context> @@ -0,0 +1,107 @@ +type CurrencyValue = { amountMicros: number; currencyCode: string } | null; +type LinkValue = { primaryLinkUrl: string | null } | null; + +type Partner = { + id: string; + name: string | null; </file context>

cubic-dev-ai · 2026-06-02T06:30:43Z

+  } catch (err) {
+    return {
+      ok: false,
+      reason: err instanceof Error ? err.message : String(err),


P2: Public route returns raw error message. This leaks internal backend details to anyone calling endpoint. Return a generic error string.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-apps/internal/twenty-partners/src/logic-functions/get-partner-by-slug.logic-function.ts, line 90: <comment>Public route returns raw error message. This leaks internal backend details to anyone calling endpoint. Return a generic error string.</comment> <file context> @@ -0,0 +1,107 @@ + } catch (err) { + return { + ok: false, + reason: err instanceof Error ? err.message : String(err), + }; + } </file context>

…y in list endpoint

…r input shape Read slug from queryStringParameters (LogicFunctionEvent shape) instead of top-level input; bump patch version to 0.3.2 for eventual deploy.

…ATED partners

…p `as any` The CoreApiClient is codegenerated from the synced workspace schema, so the `/partners` query is fully typed. Remove the type-lossy `as any` on the query and the `as Array<{ node: Partner }>` result cast, and derive the response type from the selection itself (dropping the hand-written Partner DTO that claimed `amountMicros: number` for a BigFloat and required fields for optional ones). This also fixes the latent "Property 'edges' does not exist on type '{}'" error the cast was masking.

charlesBochet · 2026-06-02T09:28:49Z

+  httpRouteTriggerSettings: {
+    path: '/partner-by-slug',
+    httpMethod: 'GET',
+    isAuthRequired: false,


@rashad @FelixMalfait are we happy about this one? we are exposing PII on a public endpoint here

We should add authentication here

I think I get it, this is supposed to be served on a public website?

even for the list? we have an authentication mecanism for the POST applications #21040

…ce, drop deploymentExpertise facet (twentyhq#21127) ## What Rebinds the marketplace's expertise facet from `deploymentExpertise` (Cloud / Self-host) to **`partnerScope`** — the five partner Categories: Advisory & Discovery · Solutioning · Custom Development · Hosting & Infrastructure · Training & Adoption. Moves the card chip, the profile facts row, the dropdown filter, the `?categories=` URL param, and the API-boundary normalization onto `partnerScope`. The standalone Cloud/Self-host facet is **dropped** (hosting is now the `HOSTING` category), per the harmonization decision. ## Depends on - The app exposing `partnerScope` — companion app PR twentyhq#21126. - The new `partnerScope` options + data migration — signup app PR twentyhq#21040. ## Tests TDD red→green on: `filter-partners`, both API normalizers, `filter-url-helpers`, `PartnerCard`, `use-filter-state`. 53/53 pass; typecheck + lint + format clean. ## Merge order (we'll decide) Independent diff. Suggested last of the four, after the signup PRs (twentyhq#21039 / twentyhq#21040) and the app PR (twentyhq#21126). Run `lingui:extract` once after twentyhq#21039 merges so the `.po` files don't conflict twice. Deploy the app + migrate before the website ships.

Bumps the `twenty-partners` SDK app version 0.3.2 → 0.3.3 so `main` tracks what's deployed to prod. This is the deploy version for the partner-app changes that just landed: marketplace `partnerScope` exposure (twentyhq#21126), the `submit-partner-application` endpoint + new Partner categories + migration (twentyhq#21040), the marketplace card rebind (twentyhq#21127), and the signup wizard (twentyhq#21039). No code changes — version bump only.

twenty-eng-sync Bot added -PR: awaiting author -PR: draft labels Jun 2, 2026

rashad mentioned this pull request Jun 2, 2026

feat(website): surface partner Categories (partnerScope) in marketplace, drop deploymentExpertise facet #21127

Merged

rashad self-assigned this Jun 2, 2026

FelixMalfait approved these changes Jun 2, 2026

View reviewed changes

rashad marked this pull request as ready for review June 2, 2026 06:26

cubic-dev-ai Bot reviewed Jun 2, 2026

View reviewed changes

rashad added 6 commits June 2, 2026 12:25

feat(partners): expose rates, linkedin, picture, skills, city, countr…

37b7404

…y in list endpoint

feat(partners): add get-partner-by-slug HTTP logic function

a38ac86

chore(partners): bump version for new HTTP endpoint + fix slug handle…

0137f3c

…r input shape Read slug from queryStringParameters (LogicFunctionEvent shape) instead of top-level input; bump patch version to 0.3.2 for eventual deploy.

feat(partners): seed rates, linkedin, picture, skills, city for VALID…

306ad94

…ATED partners

feat(twenty-partners): expose partnerScope on list + by-slug endpoints

e3f26d7

rashad force-pushed the rk-expose-rates-linkedin branch from b52bf76 to 89239d2 Compare June 2, 2026 08:25

charlesBochet reviewed Jun 2, 2026

View reviewed changes

charlesBochet requested changes Jun 2, 2026

View reviewed changes

charlesBochet approved these changes Jun 2, 2026

View reviewed changes

charlesBochet added this pull request to the merge queue Jun 2, 2026

charlesBochet added -PR: awaiting CI and removed -PR: draft -PR: awaiting author labels Jun 2, 2026

rashad removed this pull request from the merge queue due to a manual request Jun 2, 2026

rashad added this pull request to the merge queue Jun 2, 2026

Merged via the queue into main with commit a355737 Jun 2, 2026
98 checks passed

rashad deleted the rk-expose-rates-linkedin branch June 2, 2026 10:34

rashad mentioned this pull request Jun 2, 2026

chore(twenty-partners): bump app version to 0.3.3 #21140

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(twenty-partners): expose partnerScope on list + by-slug endpoints#21126

feat(twenty-partners): expose partnerScope on list + by-slug endpoints#21126
rashad merged 6 commits into
mainfrom
rk-expose-rates-linkedin

rashad commented Jun 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

twenty-ci-bot-public Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Jun 2, 2026

Uh oh!

cubic-dev-ai Bot Jun 2, 2026

Uh oh!

charlesBochet Jun 2, 2026

Uh oh!

charlesBochet Jun 2, 2026

Uh oh!

rashad Jun 2, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rashad commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Merge order (we'll decide)

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Log

Uh oh!

twenty-ci-bot-public Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Automated Pre-Review

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

charlesBochet Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

charlesBochet Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

rashad Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rashad commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading

twenty-ci-bot-public Bot commented Jun 2, 2026 •

edited

Loading