Allow overriding upload path by widget argument#99
Open
m-thielen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an optional argument to PageDownWidget named
upload_dir. If it is set,IMAGE_UPLOAD_PATHandIMAGE_UPLOAD_UNIQUEare ignored and the provided path is used instead. LikeIMAGE_UPLOAD_PATH,upload_diris inserted between MEDIA_ROOT and the image file name.If
upload_diris used, the file input element gets a new attribute "data-upload-dir-override" which is added to the POST data by the JavaScript submit handler.I also added a function that creates a unique file name for the uploaded image. This kind of overlapped with the IMAGE_UPLOAD_UNIQUE feature, but I like my solution better since UUID paths are very bulky.
make_unique_pathis only called if theupload_dirparameter is used.If you like it, I can update your README, too.