Skip to content

Adding ray job submission task#1350

Open
arunvel1988 wants to merge 4 commits into
tektoncd:mainfrom
arunvel1988:main
Open

Adding ray job submission task#1350
arunvel1988 wants to merge 4 commits into
tektoncd:mainfrom
arunvel1988:main

Conversation

@arunvel1988

Copy link
Copy Markdown
Contributor

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2025
@tekton-robot

Copy link
Copy Markdown

Hi @arunvel1988. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2025
@arunvel1988

Copy link
Copy Markdown
Contributor Author

/assign @vinamra28

@arunvel1988

Copy link
Copy Markdown
Contributor Author

@vinamra28 @imjasonh @vdemeester any update on this PR

labels:
app.kubernetes.io/version: "0.1"
annotations:
tekton.dev/pipelines.minVersion: '0.12.1'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we bump the apiVersion to a most recent version?

apiVersion: tekton.dev/v1
kind: Task
metadata:
name: ray-job-submit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task name and path doesn't match

app.kubernetes.io/version: "0.1"
annotations:
tekton.dev/pipelines.minVersion: '0.12.1'
tekton.dev/categories: "Batch,AI"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the list of categories from https://hub.tekton.dev/

@vinamra28 vinamra28 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2025
@afrittoli

Copy link
Copy Markdown
Member

/retest

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR needs a rebase against the main branch to have the CI running.

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
@arunvel1988

Copy link
Copy Markdown
Contributor Author

@vdemeester any idea why is this PR not merged with main code .. ??
@vinamra28

@arunvel1988

Copy link
Copy Markdown
Contributor Author

@vdemeester @vinamra28 @afrittoli any update ? why this pr appoved is not merged

@afrittoli

afrittoli commented May 5, 2026

Copy link
Copy Markdown
Member

@arunvel1988 Two things:

  • PR will not be merged until CI passes. The CI/lint job is failing
  • Both approval and lgtm are required (usually two reviewers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants