fix: support private company RUC with extended sequential#16
Merged
Conversation
Per SRI official communication, private company RUCs with sequential numbers exceeding 6 digits (>999999) do not have a validatable check digit. The modulo 11 validation is now skipped for these cases. Changes: - Add hasExtendedSequential() helper method to detect 7-digit sequential - Modify performPrivateCompanyRucValidation() to skip modulo 11 for extended sequential - Add unit tests for extended sequential RUCs - Update existing test to use traditional 6-digit sequential RUC
- Improve hasExtendedSequential() with better documentation and edge case handling - Add optimization: check if position 3 is '0' for quick traditional detection - Add boundary tests for sequential starting with zero and exactly 1000000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Private company RUCs with extended sequential numbers were incorrectly marked as invalid with "Check digit validation failed" error, even though they are valid in SRI.
Solution
Per SRI official communication, when the sequential number exceeds 6 digits, the modulo 11 validation should be skipped. This PR:
hasExtendedSequential()helper method to detect 7-digit sequentialperformPrivateCompanyRucValidation()to skip modulo 11 for extended sequentialTesting
All 96 tests pass.