Made it so that the ordering also checks for last name and pk when or…#3949
Merged
Conversation
…dering the member list.
ColonelPhantom
approved these changes
Jun 18, 2025
Scarletto
pushed a commit
that referenced
this pull request
Jun 25, 2025
…dering the member list. (#3949) Co-authored-by: bpc <brampc@duck.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dering the member list.
Closes #3916.
bug: some members were shown twice if they had the same name as other members
Summary
By ordering the members with last name and pk seems to have fixed it.
How to test
Make 30 users where they have the same first name but different last name. Then check in the member list if any of those members show up more then once.