All changes from closed testing of JoaD app#639
Open
ecm85 wants to merge 7 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Contributor
|
It seems compiling the card DB on this PR produced changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large set of changes, summarized thus:
added base image to base card set
Added c&c standalone expansions
"Action","Attack","Knight"
"Action","Treasure","Loot"
"Action","Victory","Castle"
"Action","Attack","Knight",Victory"
"Treasure","Attack","Loot"
"Treasure","Command"
"Treasure","Victory","Castle"
Fixed card type "Shelters" -> "Shelter" (card name was Shelters but type was Shelter)
Added group for Colony - Platinum and group tag to constituent cards
Added group for Shelters (constituent cards already had group tag)
Knights card: Added count, group_tag, group_top, correct types (added Attack and Knight)
Added individual cards for all Knights
Ruins card: Changed count to 0 (not married to this change), added group_tag and group_top
Added individual cards for all Ruins
Castles card: Changed cost 3 -> 3*, changed count to 0 (not married to this change), added group_tag and group_top
Added individual cards for all Castles
Loot card: Changed count to 0 (not married to this change), added group_tag and group_top
Added individual cards for all Loot
Added Command type to Captain, Prince, Scepter
Added missing cost to Rising Sun Events
Added c&c standalone expansions to cards from each
added "Knight"
Added text for Colony - Platinum
Added text for Castles
Added text for Knights
Fixed typo in Fortune Teller
Fixed typo in Hunting Party
Fixed typo in Masquerade
Fixed typo in Torturer
Fixed typo in Warehouse
Fixed typo in Hamlet
Fixed coins in Capital
Removed a lot of text that belongs in Extra from Knights description
Updated Loot description to be for the group
Updated Shelters description to be for the group
I ran the update_languages and also fixed all the relevant tests.