Skip to content

All changes from closed testing of JoaD app#639

Open
ecm85 wants to merge 7 commits into
sumpfork:masterfrom
ecm85:master
Open

All changes from closed testing of JoaD app#639
ecm85 wants to merge 7 commits into
sumpfork:masterfrom
ecm85:master

Conversation

@ecm85

@ecm85 ecm85 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This is a large set of changes, summarized thus:

  1. added base image
  2. sets_db
    added base image to base card set
    Added c&c standalone expansions
  3. types_db - added:
    "Action","Attack","Knight"
    "Action","Treasure","Loot"
    "Action","Victory","Castle"
    "Action","Attack","Knight",Victory"
    "Treasure","Attack","Loot"
    "Treasure","Command"
    "Treasure","Victory","Castle"
    Fixed card type "Shelters" -> "Shelter" (card name was Shelters but type was Shelter)
  4. card_db:
    Added group for Colony - Platinum and group tag to constituent cards
    Added group for Shelters (constituent cards already had group tag)
    Knights card: Added count, group_tag, group_top, correct types (added Attack and Knight)
    Added individual cards for all Knights
    Ruins card: Changed count to 0 (not married to this change), added group_tag and group_top
    Added individual cards for all Ruins
    Castles card: Changed cost 3 -> 3*, changed count to 0 (not married to this change), added group_tag and group_top
    Added individual cards for all Castles
    Loot card: Changed count to 0 (not married to this change), added group_tag and group_top
    Added individual cards for all Loot
    Added Command type to Captain, Prince, Scepter
    Added missing cost to Rising Sun Events
    Added c&c standalone expansions to cards from each
  5. types_en_us:
    added "Knight"
  6. cards_en_us:
    Added text for Colony - Platinum
    Added text for Castles
    Added text for Knights
    Fixed typo in Fortune Teller
    Fixed typo in Hunting Party
    Fixed typo in Masquerade
    Fixed typo in Torturer
    Fixed typo in Warehouse
    Fixed typo in Hamlet
    Fixed coins in Capital
    Removed a lot of text that belongs in Extra from Knights description
    Updated Loot description to be for the group
    Updated Shelters description to be for the group

I ran the update_languages and also fixed all the relevant tests.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

It seems compiling the card DB on this PR produced changes.
Ideally, please run "uv run doit update_languages" yourself on this PR and check in the results.
Otherwise, PR #640 has the necessary (but unreviewed) changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant