Skip to content

ci: add --no-system-deps flag to setup script and use in jobs #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudip-mondal-2002 merged 7 commits into from
May 29, 2026
Merged

ci: add --no-system-deps flag to setup script and use in jobs #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
016ddc5
ci: add --no-system-deps flag to setup script and use in jobs
ArjunKalirana May 25, 2026
dc8f4b4
checkout: temporary commit for worktree checkout
ArjunKalirana May 25, 2026
a5c4db4
style: use consistent double bracket syntax in setup script
ArjunKalirana May 25, 2026
8248f82
docs: add docstring to setup script and unit test for flag detection
ArjunKalirana May 25, 2026
dec0cdd
Merge branch 'main' into main
ArjunKalirana May 26, 2026
97dbd15
fix: replace C-style block comment with shell comments in setup script
ArjunKalirana May 29, 2026
d97495c
Delete tests/scripts/test_setup_dependencies.sh
sudip-mondal-2002 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ jobs:

- name: Setup External Dependencies
run: |
bash ./scripts/setup_dependencies.sh
chmod +x scripts/setup_dependencies.sh
./scripts/setup_dependencies.sh --no-system-deps

- name: Generate Version
id: version
Expand Down Expand Up @@ -196,7 +197,8 @@ jobs:

- name: Setup External Dependencies
run: |
bash ./scripts/setup_dependencies.sh
chmod +x scripts/setup_dependencies.sh
./scripts/setup_dependencies.sh --no-system-deps

- name: Generate Version
id: version
Expand Down Expand Up @@ -331,7 +333,8 @@ jobs:

- name: Setup External Dependencies
run: |
bash ./scripts/setup_dependencies.sh
chmod +x scripts/setup_dependencies.sh
./scripts/setup_dependencies.sh --no-system-deps

- name: Generate Version
id: version
Expand Down Expand Up @@ -442,7 +445,8 @@ jobs:
- name: Setup External Dependencies
shell: msys2 {0}
run: |
bash ./scripts/setup_dependencies.sh
chmod +x scripts/setup_dependencies.sh
./scripts/setup_dependencies.sh --no-system-deps

- name: Generate Version
shell: msys2 {0}
Expand Down Expand Up @@ -516,7 +520,8 @@ jobs:

- name: Setup External Dependencies
run: |
bash ./scripts/setup_dependencies.sh
chmod +x scripts/setup_dependencies.sh
./scripts/setup_dependencies.sh --no-system-deps

- name: Fetch SDL2 Java bridge
run: |
Expand Down Expand Up @@ -571,7 +576,8 @@ jobs:

- name: Setup External Dependencies
run: |
bash ./scripts/setup_dependencies.sh
chmod +x scripts/setup_dependencies.sh
./scripts/setup_dependencies.sh --no-system-deps

- name: Generate Version
id: version
Expand Down
20 changes: 15 additions & 5 deletions scripts/setup_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

set -e

SKIP_SYSTEM_DEPS=false
if [[ "$1" == "--no-system-deps" ]]; then
SKIP_SYSTEM_DEPS=true
fi

SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
EXTERNAL_DIR="$PROJECT_ROOT/external"
Expand Down Expand Up @@ -67,6 +72,10 @@ fi
echo ""
echo "Checking system dependencies..."

# install_deps - Detects the system package manager and installs required dependencies.
#
# This function checks for apt-get, dnf, pacman, or brew to install build-essential,
# cmake, portaudio, and sdl2 libraries.
install_deps() {
if command -v apt-get &> /dev/null; then
echo "Detected Debian/Ubuntu. Installing dependencies..."
Expand Down Expand Up @@ -99,16 +108,17 @@ install_deps() {
fi
}

if [ -t 0 ]; then
if [[ "$SKIP_SYSTEM_DEPS" == true ]]; then
echo "Skipping system dependency installation (--no-system-deps flag set)."
elif [ -t 0 ]; then
read -p "Install system dependencies? [y/N] " -n 1 -r
echo
if [[ ${REPLY:-N} =~ ^[Yy]$ ]]; then
install_deps
fi
else
REPLY="N"
echo "Non-interactive shell detected; skipping system dependency install prompt."
fi
if [[ ${REPLY:-N} =~ ^[Yy]$ ]]; then
install_deps
fi

echo ""
echo "=== Setup Complete ==="
Expand Down
Loading