Skip to content

adjust dockerfile and release build#8

Merged
witchpou merged 3 commits into
mainfrom
feature/ab#1746-adjust-dockerfile-and-release-build
Aug 7, 2025
Merged

adjust dockerfile and release build#8
witchpou merged 3 commits into
mainfrom
feature/ab#1746-adjust-dockerfile-and-release-build

Conversation

@witchpou

@witchpou witchpou commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Description

add non-root user to docker file. Cleanup dockerfile and use base image

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@witchpou
witchpou requested a review from Copilot August 6, 2025 16:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Docker build process and improves security by adding a non-root user to the Dockerfile, while also cleaning up build configurations and fixing version extraction in CI workflows.

  • Replaced custom Python/Poetry installation with a base image and added non-root user for security
  • Moved test target in Makefile and added actual pytest implementation
  • Fixed version extraction in GitHub workflows to prevent ambiguous matches

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Dockerfile Replaced custom build steps with base image and added non-root user security improvements
Makefile Reorganized test target and implemented actual pytest execution
start_make.sh Removed entire script file
tests/test_imports.py Added new import test for SaePositionSource
.github/workflows/create-release.yaml Fixed version extraction to use first match only
Comments suppressed due to low confidence (2)

@witchpou
witchpou requested a review from flonix8 August 6, 2025 16:34
Comment thread tests/test_imports.py Outdated
@flonix8

flonix8 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Otherwise looks good to me.

Co-authored-by: Florian Stanek <flonix8@users.noreply.github.com>
@witchpou
witchpou merged commit 4ef2b38 into main Aug 7, 2025
2 checks passed
@witchpou
witchpou deleted the feature/ab#1746-adjust-dockerfile-and-release-build branch August 7, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants