adjust dockerfile and release build#8
Merged
witchpou merged 3 commits intoAug 7, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Docker build process and improves security by adding a non-root user to the Dockerfile, while also cleaning up build configurations and fixing version extraction in CI workflows.
- Replaced custom Python/Poetry installation with a base image and added non-root user for security
- Moved test target in Makefile and added actual pytest implementation
- Fixed version extraction in GitHub workflows to prevent ambiguous matches
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile | Replaced custom build steps with base image and added non-root user security improvements |
| Makefile | Reorganized test target and implemented actual pytest execution |
| start_make.sh | Removed entire script file |
| tests/test_imports.py | Added new import test for SaePositionSource |
| .github/workflows/create-release.yaml | Fixed version extraction to use first match only |
Comments suppressed due to low confidence (2)
flonix8
reviewed
Aug 7, 2025
Contributor
|
Otherwise looks good to me. |
Co-authored-by: Florian Stanek <flonix8@users.noreply.github.com>
witchpou
deleted the
feature/ab#1746-adjust-dockerfile-and-release-build
branch
August 7, 2025 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add non-root user to docker file. Cleanup dockerfile and use base image
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: