Skip to content

Remove spike rejection from gps filter (due to the tunnel problem)#21

Merged
flonix8 merged 1 commit into
mainfrom
fix/AB#2236-fix-gps-filter-getting-stuck
May 15, 2026
Merged

Remove spike rejection from gps filter (due to the tunnel problem)#21
flonix8 merged 1 commit into
mainfrom
fix/AB#2236-fix-gps-filter-getting-stuck

Conversation

@flonix8

@flonix8 flonix8 commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description

  • Remove spike rejection
    • The filter got stuck when entering a tunnel, because the next coordinate would trigger the spike rejection
    • This could be fixed with more logic, but we realistically don't really need it, because most GPS devices should filter out single spikes (according to a lot of data we've seen so far)
  • Add test for this error mode

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@flonix8
flonix8 requested a review from ztarbug May 15, 2026 11:33
@flonix8
flonix8 merged commit 8177fb4 into main May 15, 2026
2 checks passed
@flonix8
flonix8 deleted the fix/AB#2236-fix-gps-filter-getting-stuck branch May 15, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants