some API hint fixes#3900
Merged
Merged
Conversation
cshanahan1
requested review from
MatthewPortman,
bmorris3,
gibsongreen,
haticekaratay,
javerbukh,
kecnry and
rosteen
as code owners
github-actions
Bot
added
mosviz
plugin
MatthewPortman
approved these changes
Nov 21, 2025
Member
|
Does this address "plg.ext_add_results.viewer has an API hint issue, the default is off or 'None' but the hint shows 'spectrum-viewer'. Once you toggle it, the hint fixes itself"? |
kecnry
approved these changes
Nov 24, 2025
kecnry
left a comment
kecnry
left a comment
Member
There was a problem hiding this comment.
agreed that the viewer switch issue will be deferred to a future effort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Slit Overlay Plugin for mosviz, added a PluginUserAPI and exposed 'visible', which was also added as an API hint
Reorganized items in the PluginUserAPI, made sure items that were included as API hints are also in the exposed items.