fixes for #165, #238, #210, #205#241
Open
sosey wants to merge 3 commits into
Open
Conversation
Member
Author
|
@larrybradley will you look at the changes I made for the modeling and make sure I'm not doing something stupid? |
Member
|
@sosey The Gaussian model (red line) in your figure above looks (by eye) to have a mean/center value of r > 0 (it appears to be sloping downward to the left at r=0). It should be fixed to have a mean/center at exactly r=0. |
|
Is this where I admit my ignorance, that I don't know how to check out a branch that addresses an issue? |
|
Hi - I wanted to check on updates to imexam to get correct radial profile FWHM's from 'r' command. How does one update from 0.9.1 to test? |
14 tasks
pllim
reviewed
Jun 30, 2022
Comment on lines
+176
to
+177
| fixed = {'mean': True, 'amplitude': True} | ||
| bounds = {'amplitude': (flux.max() / 2., flux.max())} |
Contributor
There was a problem hiding this comment.
I copied this setting to spacetelescope/jdaviz#1409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR attempts to fix issues with the 1D gaussian fits used in radial plots and line plots. As such it addresses some common issues in the following:
fixes #165
closes #238
closes #210
closes #205
I still need to clean up and there's likely some more minor changes to make before this PR is merged, but FWHM looks more appropriate.
@janerigby checkout this branch and let me know if you see improvement
