[WIP] feat: configurable DB path, timestamped reports, web UI tag/country buttons, test fixes#2583
[WIP] feat: configurable DB path, timestamped reports, web UI tag/country buttons, test fixes#2583JulioSilva123 wants to merge 2 commits into
Conversation
β¦uttons, test fixes
d8242af to
72334fd
Compare
|
Hey @JulioSilva123, thanks for the PR! I took a look and I'd like to ask for some changes before we can merge. A few things I noticed: The description doesn't match what's actually in the diff β it mentions In The bigger concern is the default DB location. Right now it effectively moves from The timestamped report filenames are a behavior change too. Previously running maigret twice on the same username would overwrite the report; now every run leaves a new file behind, which will pile up over time. I think this should be opt-in via a flag rather than the default. Finally, this PR bundles five pretty unrelated changes (DB path config, report timestamps, web UI buttons, flaky executor test fix, Thanks again for the work! |
Summary of changes
1. Dependency fixes
chardet7.1.0 β 5.2.0 (incompatible withrequests 2.32.3)requests2.32.5 (non-existent/spurious version) β 2.32.32. Test fixes
pytest.ini: restored to original after dependency fixtests/test_db_updater.py:137:endswith("custom/path.json")βendswith(os.path.join("custom", "path.json"))(Windows compatibility)tests/test_executors.py: async ordering asserts replaced withset()(flaky tests)3. Configurable DB path via settings.json
maigret/resources/settings.json: added"db_home_path"fieldmaigret/settings.py: addeddb_home_pathtoSettingsclass, removed~/.maigret/settings.jsonfrom path listmaigret/db_updater.py: refactored β module-level constantsMAIGRET_HOME,CACHED_DB_PATH,STATE_PATHreplaced byhomeparameter inresolve_db_pathandforce_updatemaigret/maigret.py: passessettings.db_home_pathtoresolve_db_pathandforce_update4. Timestamped report filenames
maigret/maigret.py: report filename template now includesYYYYMMDD_HHMMSS(e.g.,report_20260501_001327_johndoe_plain.html)5. Web UI β tag/country select all buttons
maigret/web/templates/index.html: added 4 buttons in the Filters section:data-group="category"ordata-group="country"attributes