Ore Revamp#710
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (279)
📒 Files selected for processing (85)
📝 WalkthroughWalkthroughAdds seven complete new armor sets (aquatic, neoplasma, plasma, platinum, ruby, silicon, team_rocket) with attachable JSONs and custom geometry models. Introduces shared base geometry files for all standard armor slots. Normalizes texture and geometry paths across all existing stone-material armor attachables. Reorganizes block, item, and terrain texture registry paths. Expands localization entries for new items and armor sets. ChangesArmor Assets and Resource Reorganization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.0)textures/terrain_texture.jsonFile contains syntax errors that prevent linting: Line 168: Expected a property but instead found '// Ores'.; Line 169: End of file expected; Line 169: End of file expected; Line 169: End of file expected; Line 171: End of file expected; Line 172: End of file expected; Line 172: End of file expected; Line 172: End of file expected; Line 174: End of file expected; Line 176: End of file expected; Line 176: End of file expected; Line 176: End of file expected; Line 178: End of file expected; Line 180: End of file expected; Line 180: End of file expected; Line 180: End of file expected; Line 182: End of file expected; Line 183: End of file expected; Line 183: End of file expected; Line 183: End of file expected; Line 185: End of file expected; Line 186: End of file expected; Line 186: End of file expected; Line 186: End of file expected; Line 188: End of file expected; Line 190: End of file expected; Line 190: End of file expected; Line 190: End of file expected; Line 192: End of file expe ... [truncated 8548 characters] ... ; Line 399: End of file expected; Line 400: End of file expected; Line 400: End of file expected; Line 400: End of file expected; Line 402: End of file expected; Line 403: End of file expected; Line 403: End of file expected; Line 403: End of file expected; Line 405: End of file expected; Line 406: End of file expected; Line 406: End of file expected; Line 406: End of file expected; Line 408: End of file expected; Line 409: End of file expected; Line 409: End of file expected; Line 409: End of file expected; Line 411: End of file expected; Line 412: End of file expected; Line 412: End of file expected; Line 412: End of file expected; Line 414: End of file expected; Line 415: End of file expected; Line 415: End of file expected; Line 415: End of file expected; Line 418: End of file expected items.jsonFile contains syntax errors that prevent linting: Line 923: Expected a property but instead found '// "pokeb:ruby": "ruby",'.; Line 926: End of file expected; Line 926: End of file expected; Line 926: End of file expected; Line 926: End of file expected; Line 927: End of file expected; Line 927: End of file expected; Line 927: End of file expected; Line 927: End of file expected; Line 928: End of file expected; Line 928: End of file expected; Line 928: End of file expected; Line 928: End of file expected; Line 929: End of file expected; Line 929: End of file expected; Line 929: End of file expected; Line 929: End of file expected; Line 930: End of file expected; Line 930: End of file expected; Line 930: End of file expected; Line 930: End of file expected; Line 931: End of file expected; Line 931: End of file expected; Line 931: End of file expected; Line 931: End of file expected; Line 932: End of file expected; Line 932: End of file expected; Line 932: End of file expected; Line 932: ... [truncated 219921 characters] ... expected; Line 2601: End of file expected; Line 2601: End of file expected; Line 2601: End of file expected; Line 2601: End of file expected; Line 2602: End of file expected; Line 2602: End of file expected; Line 2602: End of file expected; Line 2602: End of file expected; Line 2603: End of file expected; Line 2603: End of file expected; Line 2603: End of file expected; Line 2603: End of file expected; Line 2604: End of file expected; Line 2604: End of file expected; Line 2604: End of file expected; Line 2604: End of file expected; Line 2605: End of file expected; Line 2605: End of file expected; Line 2605: End of file expected; Line 2605: End of file expected; Line 2606: End of file expected; Line 2606: End of file expected; Line 2606: End of file expected; Line 2607: End of file expected Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d0b2112 to
36e2019
Compare
741b9b3 to
a8a1dfb
Compare
Summary by CodeRabbit
New Features
Chores